Synapse 1.44.0 (2021-10-05) =========================== No significant changes since 1.44.0rc3. Synapse 1.44.0rc3 (2021-10-04) ============================== Bugfixes -------- - Fix a bug introduced in Synapse v1.40.0 where changing a user's display name or avatar in a restricted room would cause an authentication error. ([\#10933](https://github.com/matrix-org/synapse/issues/10933)) - Fix `/admin/whois/{user_id}` endpoint, which was broken in v1.44.0rc1. ([\#10968](https://github.com/matrix-org/synapse/issues/10968)) Synapse 1.44.0rc2 (2021-09-30) ============================== Bugfixes -------- - Fix a bug introduced in v1.44.0rc1 which caused the experimental [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) `/batch_send` endpoint to return a 500 error. ([\#10938](https://github.com/matrix-org/synapse/issues/10938)) - Fix a bug introduced in v1.44.0rc1 which prevented sending presence events to application services. ([\#10944](https://github.com/matrix-org/synapse/issues/10944)) Improved Documentation ---------------------- - Minor updates to the installation instructions. ([\#10919](https://github.com/matrix-org/synapse/issues/10919)) Synapse 1.44.0rc1 (2021-09-29) ============================== Features -------- - Only allow the [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) `/batch_send?chunk_id=xxx` endpoint to connect to an already existing insertion event. ([\#10776](https://github.com/matrix-org/synapse/issues/10776)) - Improve oEmbed URL previews by processing the author name, photo, and video information. ([\#10814](https://github.com/matrix-org/synapse/issues/10814), [\#10819](https://github.com/matrix-org/synapse/issues/10819)) - Speed up responding with large JSON objects to requests. ([\#10868](https://github.com/matrix-org/synapse/issues/10868), [\#10905](https://github.com/matrix-org/synapse/issues/10905)) - Add a `user_may_create_room_with_invites` spam checker callback to allow modules to allow or deny a room creation request based on the invites and/or 3PID invites it includes. ([\#10898](https://github.com/matrix-org/synapse/issues/10898)) Bugfixes -------- - Fix a long-standing bug that caused an `AssertionError` when purging history in certain rooms. Contributed by @Kokokokoka. ([\#10690](https://github.com/matrix-org/synapse/issues/10690)) - Fix a long-standing bug which caused deactivated users that were later reactivated to be missing from the user directory. ([\#10782](https://github.com/matrix-org/synapse/issues/10782)) - Fix a long-standing bug that caused unbanning a user by sending a membership event to fail. Contributed by @aaronraimist. ([\#10807](https://github.com/matrix-org/synapse/issues/10807)) - Fix a long-standing bug where logging contexts would go missing when federation requests time out. ([\#10810](https://github.com/matrix-org/synapse/issues/10810)) - Fix a long-standing bug causing an error in the deprecated `/initialSync` endpoint when using the undocumented `from` and `to` parameters. ([\#10827](https://github.com/matrix-org/synapse/issues/10827)) - Fix a bug causing the `remove_stale_pushers` background job to repeatedly fail and log errors. This bug affected Synapse servers that had been upgraded from version 1.28 or older and are using SQLite. ([\#10843](https://github.com/matrix-org/synapse/issues/10843)) - Fix a long-standing bug in Unicode support of the room search admin API breaking search for rooms with non-ASCII characters. ([\#10859](https://github.com/matrix-org/synapse/issues/10859)) - Fix a bug introduced in Synapse 1.37.0 which caused `knock` membership events which we sent to remote servers to be incorrectly stored in the local database. ([\#10873](https://github.com/matrix-org/synapse/issues/10873)) - Fix invalidating one-time key count cache after claiming keys. The bug was introduced in Synapse v1.41.0. Contributed by Tulir at Beeper. ([\#10875](https://github.com/matrix-org/synapse/issues/10875)) - Fix a long-standing bug causing application service users to be subject to MAU blocking if the MAU limit had been reached, even if configured not to be blocked. ([\#10881](https://github.com/matrix-org/synapse/issues/10881)) - Fix a long-standing bug which could cause events pulled over federation to be incorrectly rejected. ([\#10907](https://github.com/matrix-org/synapse/issues/10907)) - Fix a long-standing bug causing URL cache files to be stored in storage providers. Server admins may safely delete the `url_cache/` and `url_cache_thumbnails/` directories from any configured storage providers to reclaim space. ([\#10911](https://github.com/matrix-org/synapse/issues/10911)) - Fix a long-standing bug leading to race conditions when creating media store and config directories. ([\#10913](https://github.com/matrix-org/synapse/issues/10913)) Improved Documentation ---------------------- - Fix some crashes in the Module API example code, by adding JSON encoding/decoding. ([\#10845](https://github.com/matrix-org/synapse/issues/10845)) - Add developer documentation about experimental configuration flags. ([\#10865](https://github.com/matrix-org/synapse/issues/10865)) - Properly remove deleted files from GitHub pages when generating the documentation. ([\#10869](https://github.com/matrix-org/synapse/issues/10869)) Internal Changes ---------------- - Fix GitHub Actions config so we can run sytest on synapse from parallel branches. ([\#10659](https://github.com/matrix-org/synapse/issues/10659)) - Split out [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) meta events to their own fields in the `/batch_send` response. ([\#10777](https://github.com/matrix-org/synapse/issues/10777)) - Add missing type hints to REST servlets. ([\#10785](https://github.com/matrix-org/synapse/issues/10785), [\#10817](https://github.com/matrix-org/synapse/issues/10817)) - Simplify the internal logic which maintains the user directory database tables. ([\#10796](https://github.com/matrix-org/synapse/issues/10796)) - Use direct references to config flags. ([\#10812](https://github.com/matrix-org/synapse/issues/10812), [\#10885](https://github.com/matrix-org/synapse/issues/10885), [\#10893](https://github.com/matrix-org/synapse/issues/10893), [\#10897](https://github.com/matrix-org/synapse/issues/10897)) - Specify the type of token in generic "Invalid token" error messages. ([\#10815](https://github.com/matrix-org/synapse/issues/10815)) - Make `StateFilter` frozen so it is hashable. ([\#10816](https://github.com/matrix-org/synapse/issues/10816)) - Fix a long-standing bug where an `m.room.message` event containing a null byte would cause an internal server error. ([\#10820](https://github.com/matrix-org/synapse/issues/10820)) - Add type hints to the state database. ([\#10823](https://github.com/matrix-org/synapse/issues/10823)) - Opt out of cache expiry for `get_users_who_share_room_with_user`, to hopefully improve `/sync` performance when you haven't synced recently. ([\#10826](https://github.com/matrix-org/synapse/issues/10826)) - Track cache eviction rates more finely in Prometheus's monitoring. ([\#10829](https://github.com/matrix-org/synapse/issues/10829)) - Add missing type hints to `synapse.handlers`. ([\#10831](https://github.com/matrix-org/synapse/issues/10831), [\#10856](https://github.com/matrix-org/synapse/issues/10856)) - Extend the Module API to let plug-ins check whether an ID is local and to access IP + User Agent data. ([\#10833](https://github.com/matrix-org/synapse/issues/10833)) - Factor out PNG image data to a constant to be used in several tests. ([\#10834](https://github.com/matrix-org/synapse/issues/10834)) - Add a test to ensure state events sent by modules get persisted correctly. ([\#10835](https://github.com/matrix-org/synapse/issues/10835)) - Rename [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) fields and event types from `chunk` to `batch` to match the `/batch_send` endpoint. ([\#10838](https://github.com/matrix-org/synapse/issues/10838)) - Rename [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) `/batch_send` query parameter from `?prev_event` to more obvious usage with `?prev_event_id`. ([\#10839](https://github.com/matrix-org/synapse/issues/10839)) - Add type hints to `synapse.http.site`. ([\#10867](https://github.com/matrix-org/synapse/issues/10867)) - Include outlier status when we log V2 or V3 events. ([\#10879](https://github.com/matrix-org/synapse/issues/10879)) - Break down Grafana's cache expiry time series based on reason for eviction, c.f. [\#10829](https://github.com/matrix-org/synapse/issues/10829). ([\#10880](https://github.com/matrix-org/synapse/issues/10880)) - Clean up some of the federation event authentication code for clarity. ([\#10883](https://github.com/matrix-org/synapse/issues/10883), [\#10884](https://github.com/matrix-org/synapse/issues/10884), [\#10896](https://github.com/matrix-org/synapse/issues/10896), [\#10901](https://github.com/matrix-org/synapse/issues/10901)) - Allow the `.` and `~` characters when creating registration tokens as per the change to [MSC3231](https://github.com/matrix-org/matrix-doc/pull/3231). ([\#10887](https://github.com/matrix-org/synapse/issues/10887)) - Clean up some unnecessary parentheses in places around the codebase. ([\#10889](https://github.com/matrix-org/synapse/issues/10889)) - Improve type hinting in the user directory code. ([\#10891](https://github.com/matrix-org/synapse/issues/10891)) - Update development testing script `test_postgresql.sh` to use a supported Python version and make re-runs quicker. ([\#10906](https://github.com/matrix-org/synapse/issues/10906)) - Document and summarize changes in schema version `61` – `64`. ([\#10917](https://github.com/matrix-org/synapse/issues/10917)) - Update release script to sign the newly created git tags. ([\#10925](https://github.com/matrix-org/synapse/issues/10925)) - Fix Debian builds due to `dh-virtualenv` no longer being able to build their docs. ([\#10931](https://github.com/matrix-org/synapse/issues/10931))
611 lines
23 KiB
Python
611 lines
23 KiB
Python
# Copyright 2020 The Matrix.org Foundation C.I.C.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
from unittest.mock import Mock
|
|
|
|
from twisted.internet import defer
|
|
|
|
from synapse.api.constants import EduTypes, EventTypes
|
|
from synapse.events import EventBase
|
|
from synapse.federation.units import Transaction
|
|
from synapse.handlers.presence import UserPresenceState
|
|
from synapse.rest import admin
|
|
from synapse.rest.client import login, presence, room
|
|
from synapse.types import create_requester
|
|
|
|
from tests.events.test_presence_router import send_presence_update, sync_presence
|
|
from tests.replication._base import BaseMultiWorkerStreamTestCase
|
|
from tests.test_utils.event_injection import inject_member_event
|
|
from tests.unittest import HomeserverTestCase, override_config
|
|
from tests.utils import USE_POSTGRES_FOR_TESTS
|
|
|
|
|
|
class ModuleApiTestCase(HomeserverTestCase):
|
|
servlets = [
|
|
admin.register_servlets,
|
|
login.register_servlets,
|
|
room.register_servlets,
|
|
presence.register_servlets,
|
|
]
|
|
|
|
def prepare(self, reactor, clock, homeserver):
|
|
self.store = homeserver.get_datastore()
|
|
self.module_api = homeserver.get_module_api()
|
|
self.event_creation_handler = homeserver.get_event_creation_handler()
|
|
self.sync_handler = homeserver.get_sync_handler()
|
|
self.auth_handler = homeserver.get_auth_handler()
|
|
|
|
def make_homeserver(self, reactor, clock):
|
|
return self.setup_test_homeserver(
|
|
federation_transport_client=Mock(spec=["send_transaction"]),
|
|
)
|
|
|
|
def test_can_register_user(self):
|
|
"""Tests that an external module can register a user"""
|
|
# Register a new user
|
|
user_id, access_token = self.get_success(
|
|
self.module_api.register(
|
|
"bob", displayname="Bobberino", emails=["bob@bobinator.bob"]
|
|
)
|
|
)
|
|
|
|
# Check that the new user exists with all provided attributes
|
|
self.assertEqual(user_id, "@bob:test")
|
|
self.assertTrue(access_token)
|
|
self.assertTrue(self.get_success(self.store.get_user_by_id(user_id)))
|
|
|
|
# Check that the email was assigned
|
|
emails = self.get_success(self.store.user_get_threepids(user_id))
|
|
self.assertEqual(len(emails), 1)
|
|
|
|
email = emails[0]
|
|
self.assertEqual(email["medium"], "email")
|
|
self.assertEqual(email["address"], "bob@bobinator.bob")
|
|
|
|
# Should these be 0?
|
|
self.assertEqual(email["validated_at"], 0)
|
|
self.assertEqual(email["added_at"], 0)
|
|
|
|
# Check that the displayname was assigned
|
|
displayname = self.get_success(self.store.get_profile_displayname("bob"))
|
|
self.assertEqual(displayname, "Bobberino")
|
|
|
|
def test_get_userinfo_by_id(self):
|
|
user_id = self.register_user("alice", "1234")
|
|
found_user = self.get_success(self.module_api.get_userinfo_by_id(user_id))
|
|
self.assertEqual(found_user.user_id.to_string(), user_id)
|
|
self.assertIdentical(found_user.is_admin, False)
|
|
|
|
def test_get_userinfo_by_id__no_user_found(self):
|
|
found_user = self.get_success(self.module_api.get_userinfo_by_id("@alice:test"))
|
|
self.assertIsNone(found_user)
|
|
|
|
def test_get_user_ip_and_agents(self):
|
|
user_id = self.register_user("test_get_user_ip_and_agents_user", "1234")
|
|
|
|
# Initially, we should have no ip/agent for our user.
|
|
info = self.get_success(self.module_api.get_user_ip_and_agents(user_id))
|
|
self.assertEqual(info, [])
|
|
|
|
# Insert a first ip, agent. We should be able to retrieve it.
|
|
self.get_success(
|
|
self.store.insert_client_ip(
|
|
user_id, "access_token", "ip_1", "user_agent_1", "device_1", None
|
|
)
|
|
)
|
|
info = self.get_success(self.module_api.get_user_ip_and_agents(user_id))
|
|
|
|
self.assertEqual(len(info), 1)
|
|
last_seen_1 = info[0].last_seen
|
|
|
|
# Insert a second ip, agent at a later date. We should be able to retrieve it.
|
|
last_seen_2 = last_seen_1 + 10000
|
|
print("%s => %s" % (last_seen_1, last_seen_2))
|
|
self.get_success(
|
|
self.store.insert_client_ip(
|
|
user_id, "access_token", "ip_2", "user_agent_2", "device_2", last_seen_2
|
|
)
|
|
)
|
|
info = self.get_success(self.module_api.get_user_ip_and_agents(user_id))
|
|
|
|
self.assertEqual(len(info), 2)
|
|
ip_1_seen = False
|
|
ip_2_seen = False
|
|
|
|
for i in info:
|
|
if i.ip == "ip_1":
|
|
ip_1_seen = True
|
|
self.assertEqual(i.user_agent, "user_agent_1")
|
|
self.assertEqual(i.last_seen, last_seen_1)
|
|
elif i.ip == "ip_2":
|
|
ip_2_seen = True
|
|
self.assertEqual(i.user_agent, "user_agent_2")
|
|
self.assertEqual(i.last_seen, last_seen_2)
|
|
self.assertTrue(ip_1_seen)
|
|
self.assertTrue(ip_2_seen)
|
|
|
|
# If we fetch from a midpoint between last_seen_1 and last_seen_2,
|
|
# we should only find the second ip, agent.
|
|
info = self.get_success(
|
|
self.module_api.get_user_ip_and_agents(
|
|
user_id, (last_seen_1 + last_seen_2) / 2
|
|
)
|
|
)
|
|
self.assertEqual(len(info), 1)
|
|
self.assertEqual(info[0].ip, "ip_2")
|
|
self.assertEqual(info[0].user_agent, "user_agent_2")
|
|
self.assertEqual(info[0].last_seen, last_seen_2)
|
|
|
|
# If we fetch from a point later than last_seen_2, we shouldn't
|
|
# find anything.
|
|
info = self.get_success(
|
|
self.module_api.get_user_ip_and_agents(user_id, last_seen_2 + 10000)
|
|
)
|
|
self.assertEqual(info, [])
|
|
|
|
def test_get_user_ip_and_agents__no_user_found(self):
|
|
info = self.get_success(
|
|
self.module_api.get_user_ip_and_agents(
|
|
"@test_get_user_ip_and_agents_user_nonexistent:example.com"
|
|
)
|
|
)
|
|
self.assertEqual(info, [])
|
|
|
|
def test_sending_events_into_room(self):
|
|
"""Tests that a module can send events into a room"""
|
|
# Mock out create_and_send_nonmember_event to check whether events are being sent
|
|
self.event_creation_handler.create_and_send_nonmember_event = Mock(
|
|
spec=[],
|
|
side_effect=self.event_creation_handler.create_and_send_nonmember_event,
|
|
)
|
|
|
|
# Create a user and room to play with
|
|
user_id = self.register_user("summer", "monkey")
|
|
tok = self.login("summer", "monkey")
|
|
room_id = self.helper.create_room_as(user_id, tok=tok)
|
|
|
|
# Create and send a non-state event
|
|
content = {"body": "I am a puppet", "msgtype": "m.text"}
|
|
event_dict = {
|
|
"room_id": room_id,
|
|
"type": "m.room.message",
|
|
"content": content,
|
|
"sender": user_id,
|
|
}
|
|
event: EventBase = self.get_success(
|
|
self.module_api.create_and_send_event_into_room(event_dict)
|
|
)
|
|
self.assertEqual(event.sender, user_id)
|
|
self.assertEqual(event.type, "m.room.message")
|
|
self.assertEqual(event.room_id, room_id)
|
|
self.assertFalse(hasattr(event, "state_key"))
|
|
self.assertDictEqual(event.content, content)
|
|
|
|
expected_requester = create_requester(
|
|
user_id, authenticated_entity=self.hs.hostname
|
|
)
|
|
|
|
# Check that the event was sent
|
|
self.event_creation_handler.create_and_send_nonmember_event.assert_called_with(
|
|
expected_requester,
|
|
event_dict,
|
|
ratelimit=False,
|
|
ignore_shadow_ban=True,
|
|
)
|
|
|
|
# Create and send a state event
|
|
content = {
|
|
"events_default": 0,
|
|
"users": {user_id: 100},
|
|
"state_default": 50,
|
|
"users_default": 0,
|
|
"events": {"test.event.type": 25},
|
|
}
|
|
event_dict = {
|
|
"room_id": room_id,
|
|
"type": "m.room.power_levels",
|
|
"content": content,
|
|
"sender": user_id,
|
|
"state_key": "",
|
|
}
|
|
event: EventBase = self.get_success(
|
|
self.module_api.create_and_send_event_into_room(event_dict)
|
|
)
|
|
self.assertEqual(event.sender, user_id)
|
|
self.assertEqual(event.type, "m.room.power_levels")
|
|
self.assertEqual(event.room_id, room_id)
|
|
self.assertEqual(event.state_key, "")
|
|
self.assertDictEqual(event.content, content)
|
|
|
|
# Check that the event was sent
|
|
self.event_creation_handler.create_and_send_nonmember_event.assert_called_with(
|
|
expected_requester,
|
|
{
|
|
"type": "m.room.power_levels",
|
|
"content": content,
|
|
"room_id": room_id,
|
|
"sender": user_id,
|
|
"state_key": "",
|
|
},
|
|
ratelimit=False,
|
|
ignore_shadow_ban=True,
|
|
)
|
|
|
|
# Check that we can't send membership events
|
|
content = {
|
|
"membership": "leave",
|
|
}
|
|
event_dict = {
|
|
"room_id": room_id,
|
|
"type": "m.room.member",
|
|
"content": content,
|
|
"sender": user_id,
|
|
"state_key": user_id,
|
|
}
|
|
self.get_failure(
|
|
self.module_api.create_and_send_event_into_room(event_dict), Exception
|
|
)
|
|
|
|
def test_public_rooms(self):
|
|
"""Tests that a room can be added and removed from the public rooms list,
|
|
as well as have its public rooms directory state queried.
|
|
"""
|
|
# Create a user and room to play with
|
|
user_id = self.register_user("kermit", "monkey")
|
|
tok = self.login("kermit", "monkey")
|
|
room_id = self.helper.create_room_as(user_id, tok=tok)
|
|
|
|
# The room should not currently be in the public rooms directory
|
|
is_in_public_rooms = self.get_success(
|
|
self.module_api.public_room_list_manager.room_is_in_public_room_list(
|
|
room_id
|
|
)
|
|
)
|
|
self.assertFalse(is_in_public_rooms)
|
|
|
|
# Let's try adding it to the public rooms directory
|
|
self.get_success(
|
|
self.module_api.public_room_list_manager.add_room_to_public_room_list(
|
|
room_id
|
|
)
|
|
)
|
|
|
|
# And checking whether it's in there...
|
|
is_in_public_rooms = self.get_success(
|
|
self.module_api.public_room_list_manager.room_is_in_public_room_list(
|
|
room_id
|
|
)
|
|
)
|
|
self.assertTrue(is_in_public_rooms)
|
|
|
|
# Let's remove it again
|
|
self.get_success(
|
|
self.module_api.public_room_list_manager.remove_room_from_public_room_list(
|
|
room_id
|
|
)
|
|
)
|
|
|
|
# Should be gone
|
|
is_in_public_rooms = self.get_success(
|
|
self.module_api.public_room_list_manager.room_is_in_public_room_list(
|
|
room_id
|
|
)
|
|
)
|
|
self.assertFalse(is_in_public_rooms)
|
|
|
|
def test_send_local_online_presence_to(self):
|
|
# Test sending local online presence to users from the main process
|
|
_test_sending_local_online_presence_to_local_user(self, test_with_workers=False)
|
|
|
|
@override_config({"send_federation": True})
|
|
def test_send_local_online_presence_to_federation(self):
|
|
"""Tests that send_local_presence_to_users sends local online presence to remote users."""
|
|
# Create a user who will send presence updates
|
|
self.presence_sender_id = self.register_user("presence_sender1", "monkey")
|
|
self.presence_sender_tok = self.login("presence_sender1", "monkey")
|
|
|
|
# And a room they're a part of
|
|
room_id = self.helper.create_room_as(
|
|
self.presence_sender_id,
|
|
tok=self.presence_sender_tok,
|
|
)
|
|
|
|
# Mark them as online
|
|
send_presence_update(
|
|
self,
|
|
self.presence_sender_id,
|
|
self.presence_sender_tok,
|
|
"online",
|
|
"I'm online!",
|
|
)
|
|
|
|
# Make up a remote user to send presence to
|
|
remote_user_id = "@far_away_person:island"
|
|
|
|
# Create a join membership event for the remote user into the room.
|
|
# This allows presence information to flow from one user to the other.
|
|
self.get_success(
|
|
inject_member_event(
|
|
self.hs,
|
|
room_id,
|
|
sender=remote_user_id,
|
|
target=remote_user_id,
|
|
membership="join",
|
|
)
|
|
)
|
|
|
|
# The remote user would have received the existing room members' presence
|
|
# when they joined the room.
|
|
#
|
|
# Thus we reset the mock, and try sending online local user
|
|
# presence again
|
|
self.hs.get_federation_transport_client().send_transaction.reset_mock()
|
|
|
|
# Broadcast local user online presence
|
|
self.get_success(
|
|
self.module_api.send_local_online_presence_to([remote_user_id])
|
|
)
|
|
|
|
# Check that a presence update was sent as part of a federation transaction
|
|
found_update = False
|
|
calls = (
|
|
self.hs.get_federation_transport_client().send_transaction.call_args_list
|
|
)
|
|
for call in calls:
|
|
call_args = call[0]
|
|
federation_transaction: Transaction = call_args[0]
|
|
|
|
# Get the sent EDUs in this transaction
|
|
edus = federation_transaction.get_dict()["edus"]
|
|
|
|
for edu in edus:
|
|
# Make sure we're only checking presence-type EDUs
|
|
if edu["edu_type"] != EduTypes.Presence:
|
|
continue
|
|
|
|
# EDUs can contain multiple presence updates
|
|
for presence_update in edu["content"]["push"]:
|
|
if presence_update["user_id"] == self.presence_sender_id:
|
|
found_update = True
|
|
|
|
self.assertTrue(found_update)
|
|
|
|
def test_get_room_state(self):
|
|
"""Tests that a module can retrieve the state of a room through the module API."""
|
|
user_id = self.register_user("peter", "hackme")
|
|
tok = self.login("peter", "hackme")
|
|
|
|
# Create a room and send some custom state in it.
|
|
room_id = self.helper.create_room_as(tok=tok)
|
|
self.helper.send_state(room_id, "org.matrix.test", {}, tok=tok)
|
|
|
|
# Check that the module API can successfully fetch state for the room.
|
|
state = self.get_success(
|
|
defer.ensureDeferred(self.module_api.get_room_state(room_id))
|
|
)
|
|
|
|
# Check that a few standard events are in the returned state.
|
|
self.assertIn((EventTypes.Create, ""), state)
|
|
self.assertIn((EventTypes.Member, user_id), state)
|
|
|
|
# Check that our custom state event is in the returned state.
|
|
self.assertEqual(state[("org.matrix.test", "")].sender, user_id)
|
|
self.assertEqual(state[("org.matrix.test", "")].state_key, "")
|
|
self.assertEqual(state[("org.matrix.test", "")].content, {})
|
|
|
|
|
|
class ModuleApiWorkerTestCase(BaseMultiWorkerStreamTestCase):
|
|
"""For testing ModuleApi functionality in a multi-worker setup"""
|
|
|
|
# Testing stream ID replication from the main to worker processes requires postgres
|
|
# (due to needing `MultiWriterIdGenerator`).
|
|
if not USE_POSTGRES_FOR_TESTS:
|
|
skip = "Requires Postgres"
|
|
|
|
servlets = [
|
|
admin.register_servlets,
|
|
login.register_servlets,
|
|
room.register_servlets,
|
|
presence.register_servlets,
|
|
]
|
|
|
|
def default_config(self):
|
|
conf = super().default_config()
|
|
conf["redis"] = {"enabled": "true"}
|
|
conf["stream_writers"] = {"presence": ["presence_writer"]}
|
|
conf["instance_map"] = {
|
|
"presence_writer": {"host": "testserv", "port": 1001},
|
|
}
|
|
return conf
|
|
|
|
def prepare(self, reactor, clock, homeserver):
|
|
self.module_api = homeserver.get_module_api()
|
|
self.sync_handler = homeserver.get_sync_handler()
|
|
|
|
def test_send_local_online_presence_to_workers(self):
|
|
# Test sending local online presence to users from a worker process
|
|
_test_sending_local_online_presence_to_local_user(self, test_with_workers=True)
|
|
|
|
|
|
def _test_sending_local_online_presence_to_local_user(
|
|
test_case: HomeserverTestCase, test_with_workers: bool = False
|
|
):
|
|
"""Tests that send_local_presence_to_users sends local online presence to local users.
|
|
|
|
This simultaneously tests two different usecases:
|
|
* Testing that this method works when either called from a worker or the main process.
|
|
- We test this by calling this method from both a TestCase that runs in monolith mode, and one that
|
|
runs with a main and generic_worker.
|
|
* Testing that multiple devices syncing simultaneously will all receive a snapshot of local,
|
|
online presence - but only once per device.
|
|
|
|
Args:
|
|
test_with_workers: If True, this method will call ModuleApi.send_local_online_presence_to on a
|
|
worker process. The test users will still sync with the main process. The purpose of testing
|
|
with a worker is to check whether a Synapse module running on a worker can inform other workers/
|
|
the main process that they should include additional presence when a user next syncs.
|
|
"""
|
|
if test_with_workers:
|
|
# Create a worker process to make module_api calls against
|
|
worker_hs = test_case.make_worker_hs(
|
|
"synapse.app.generic_worker", {"worker_name": "presence_writer"}
|
|
)
|
|
|
|
# Create a user who will send presence updates
|
|
test_case.presence_receiver_id = test_case.register_user(
|
|
"presence_receiver1", "monkey"
|
|
)
|
|
test_case.presence_receiver_tok = test_case.login("presence_receiver1", "monkey")
|
|
|
|
# And another user that will send presence updates out
|
|
test_case.presence_sender_id = test_case.register_user("presence_sender2", "monkey")
|
|
test_case.presence_sender_tok = test_case.login("presence_sender2", "monkey")
|
|
|
|
# Put them in a room together so they will receive each other's presence updates
|
|
room_id = test_case.helper.create_room_as(
|
|
test_case.presence_receiver_id,
|
|
tok=test_case.presence_receiver_tok,
|
|
)
|
|
test_case.helper.join(
|
|
room_id, test_case.presence_sender_id, tok=test_case.presence_sender_tok
|
|
)
|
|
|
|
# Presence sender comes online
|
|
send_presence_update(
|
|
test_case,
|
|
test_case.presence_sender_id,
|
|
test_case.presence_sender_tok,
|
|
"online",
|
|
"I'm online!",
|
|
)
|
|
|
|
# Presence receiver should have received it
|
|
presence_updates, sync_token = sync_presence(
|
|
test_case, test_case.presence_receiver_id
|
|
)
|
|
test_case.assertEqual(len(presence_updates), 1)
|
|
|
|
presence_update: UserPresenceState = presence_updates[0]
|
|
test_case.assertEqual(presence_update.user_id, test_case.presence_sender_id)
|
|
test_case.assertEqual(presence_update.state, "online")
|
|
|
|
if test_with_workers:
|
|
# Replicate the current sync presence token from the main process to the worker process.
|
|
# We need to do this so that the worker process knows the current presence stream ID to
|
|
# insert into the database when we call ModuleApi.send_local_online_presence_to.
|
|
test_case.replicate()
|
|
|
|
# Syncing again should result in no presence updates
|
|
presence_updates, sync_token = sync_presence(
|
|
test_case, test_case.presence_receiver_id, sync_token
|
|
)
|
|
test_case.assertEqual(len(presence_updates), 0)
|
|
|
|
# We do an (initial) sync with a second "device" now, getting a new sync token.
|
|
# We'll use this in a moment.
|
|
_, sync_token_second_device = sync_presence(
|
|
test_case, test_case.presence_receiver_id
|
|
)
|
|
|
|
# Determine on which process (main or worker) to call ModuleApi.send_local_online_presence_to on
|
|
if test_with_workers:
|
|
module_api_to_use = worker_hs.get_module_api()
|
|
else:
|
|
module_api_to_use = test_case.module_api
|
|
|
|
# Trigger sending local online presence. We expect this information
|
|
# to be saved to the database where all processes can access it.
|
|
# Note that we're syncing via the master.
|
|
d = module_api_to_use.send_local_online_presence_to(
|
|
[
|
|
test_case.presence_receiver_id,
|
|
]
|
|
)
|
|
d = defer.ensureDeferred(d)
|
|
|
|
if test_with_workers:
|
|
# In order for the required presence_set_state replication request to occur between the
|
|
# worker and main process, we need to pump the reactor. Otherwise, the coordinator that
|
|
# reads the request on the main process won't do so, and the request will time out.
|
|
while not d.called:
|
|
test_case.reactor.advance(0.1)
|
|
|
|
test_case.get_success(d)
|
|
|
|
# The presence receiver should have received online presence again.
|
|
presence_updates, sync_token = sync_presence(
|
|
test_case, test_case.presence_receiver_id, sync_token
|
|
)
|
|
test_case.assertEqual(len(presence_updates), 1)
|
|
|
|
presence_update: UserPresenceState = presence_updates[0]
|
|
test_case.assertEqual(presence_update.user_id, test_case.presence_sender_id)
|
|
test_case.assertEqual(presence_update.state, "online")
|
|
|
|
# We attempt to sync with the second sync token we received above - just to check that
|
|
# multiple syncing devices will each receive the necessary online presence.
|
|
presence_updates, sync_token_second_device = sync_presence(
|
|
test_case, test_case.presence_receiver_id, sync_token_second_device
|
|
)
|
|
test_case.assertEqual(len(presence_updates), 1)
|
|
|
|
presence_update: UserPresenceState = presence_updates[0]
|
|
test_case.assertEqual(presence_update.user_id, test_case.presence_sender_id)
|
|
test_case.assertEqual(presence_update.state, "online")
|
|
|
|
# However, if we now sync with either "device", we won't receive another burst of online presence
|
|
# until the API is called again sometime in the future
|
|
presence_updates, sync_token = sync_presence(
|
|
test_case, test_case.presence_receiver_id, sync_token
|
|
)
|
|
|
|
# Now we check that we don't receive *offline* updates using ModuleApi.send_local_online_presence_to.
|
|
|
|
# Presence sender goes offline
|
|
send_presence_update(
|
|
test_case,
|
|
test_case.presence_sender_id,
|
|
test_case.presence_sender_tok,
|
|
"offline",
|
|
"I slink back into the darkness.",
|
|
)
|
|
|
|
# Presence receiver should have received the updated, offline state
|
|
presence_updates, sync_token = sync_presence(
|
|
test_case, test_case.presence_receiver_id, sync_token
|
|
)
|
|
test_case.assertEqual(len(presence_updates), 1)
|
|
|
|
# Now trigger sending local online presence.
|
|
d = module_api_to_use.send_local_online_presence_to(
|
|
[
|
|
test_case.presence_receiver_id,
|
|
]
|
|
)
|
|
d = defer.ensureDeferred(d)
|
|
|
|
if test_with_workers:
|
|
# In order for the required presence_set_state replication request to occur between the
|
|
# worker and main process, we need to pump the reactor. Otherwise, the coordinator that
|
|
# reads the request on the main process won't do so, and the request will time out.
|
|
while not d.called:
|
|
test_case.reactor.advance(0.1)
|
|
|
|
test_case.get_success(d)
|
|
|
|
# Presence receiver should *not* have received offline state
|
|
presence_updates, sync_token = sync_presence(
|
|
test_case, test_case.presence_receiver_id, sync_token
|
|
)
|
|
test_case.assertEqual(len(presence_updates), 0)
|