Highlight exactly where the remote server drops the disinvite event

Attempt 1 didn't work because the remote server isn't expecting to
receive a `leave` negotiation. Instead, we should try sending the
event over a transaction so that the remote can deal with it as it
would any other leave event.

synapse/federation/federation_server.py

@@ -195,6 +195,7 @@ class FederationServer(FederationBase):
                 )
                 continue
 
+            # TODO: Somehow trick the following into accepting disinvite events.
             try:
                 room_version = yield self.store.get_room_version(room_id)
                 format_ver = room_version_to_event_format(room_version)

synapse/federation/transaction_queue.py

@@ -22,6 +22,7 @@ from prometheus_client import Counter
 from twisted.internet import defer
 
 import synapse.metrics
+from synapse.api.constants import EventTypes, Membership
 from synapse.api.errors import (
     FederationDeniedError,
     HttpResponseException,
@@ -36,6 +37,7 @@ from synapse.metrics import (
     sent_transactions_counter,
 )
 from synapse.metrics.background_process_metrics import run_as_background_process
+from synapse.types import UserID
 from synapse.util import logcontext
 from synapse.util.metrics import measure_func
 from synapse.util.retryutils import NotRetryingDestination, get_retry_limiter
@@ -202,6 +204,17 @@ class TransactionQueue(object):
                         destinations = yield self.state.get_current_hosts_in_room(
                             event.room_id, latest_event_ids=event.prev_event_ids(),
                         )
+
+                        # Special case leaves: We could be disinviting the host or
+                        # unbanning them, so send the event to the host if they are
+                        # not already in the list. The event affects their membership,
+                        # so they have a moderate right to know what's going on.
+                        if event.type == EventTypes.Member and (event.membership ==
+                                                                Membership.LEAVE):
+                            target_user = UserID.from_string(event.state_key)
+                            if target_user.domain not in destinations:
+                                destinations = set(destinations)
+                                destinations.add(target_user.domain)
                     except Exception:
                         logger.exception(
                             "Failed to calculate hosts in room for event: %s",

synapse/handlers/room_member.py

@@ -452,6 +452,9 @@ class RoomMemberHandler(object):
                     )
 
         is_host_in_room = yield self._is_host_in_room(current_state_ids)
+        logger.info("Is host in room? %s" % is_host_in_room)
+        logger.info("effective_membership_state %s" % effective_membership_state)
+        logger.info("remote_room_hosts %s" % remote_room_hosts)
 
         if effective_membership_state == Membership.JOIN:
             if requester.is_guest:

synapse/handlers/sync.py

@@ -1386,6 +1386,7 @@ class SyncHandler(object):
 
         mem_change_events_by_room_id = {}
         for event in rooms_changed:
+            logger.warn("Membership %s" % event.room_id)
             mem_change_events_by_room_id.setdefault(event.room_id, []).append(event)
 
         newly_joined_rooms = []