Merge branch 'develop' into travis/auth-always-on

2024-11-18 09:19:18 -07:00 · 2024-11-07 09:57:41 -07:00 · 2024-10-30 11:00:13 -06:00 · 2024-10-30 10:58:34 -06:00 · 2024-10-30 10:56:24 -06:00 · 2024-10-30 09:59:28 -06:00
3 changed files with 4 additions and 6 deletions
--- a/changelog.d/17889.feature
+++ b/changelog.d/17889.feature
@@ -0,0 +1 @@
+Set `enable_authenticated_media` to `true` by default. In a future release of Synapse, this option will be removed and become always-on.
--- a/docs/usage/configuration/config_documentation.md
+++ b/docs/usage/configuration/config_documentation.md
@@ -1887,8 +1887,7 @@ Config options related to Synapse's media store.

 When set to true, all subsequent media uploads will be marked as authenticated, and will not be available over legacy
 unauthenticated media endpoints (`/_matrix/media/(r0|v3|v1)/download` and `/_matrix/media/(r0|v3|v1)/thumbnail`) - requests for authenticated media over these endpoints will result in a 404. All media, including authenticated media, will be available over the authenticated media endpoints `_matrix/client/v1/media/download` and `_matrix/client/v1/media/thumbnail`. Media uploaded prior to setting this option to true will still be available over the legacy endpoints. Note if the setting is switched to false
-after enabling, media marked as authenticated will be available over legacy endpoints. Defaults to false, but
-this will change to true in a future Synapse release.
+after enabling, media marked as authenticated will be available over legacy endpoints. Defaults to true (previously false). In a future release of Synapse, this option will be removed and become always-on.

 In all cases, authenticated requests to download media will succeed, but for unauthenticated requests, this
 case-by-case breakdown describes whether media downloads are permitted:
@@ -1912,7 +1911,7 @@ those older clients or homeservers will not be cut off from media they can alrea

 Example configuration:
 ```yaml
-enable_authenticated_media: true
+enable_authenticated_media: false
 ```
 ---
 ### `enable_media_repo`
--- a/synapse/config/repository.py
+++ b/synapse/config/repository.py
@@ -272,9 +272,7 @@ class ContentRepositoryConfig(Config):
                remote_media_lifetime
            )

-        self.enable_authenticated_media = config.get(
-            "enable_authenticated_media", False
-        )
+        self.enable_authenticated_media = config.get("enable_authenticated_media", True)

    def generate_config_section(self, data_dir_path: str, **kwargs: Any) -> str:
        assert data_dir_path is not None
Author	SHA1	Message	Date
Travis Ralston	09649fce2a	Merge branch 'develop' into travis/auth-always-on	2024-11-18 09:19:18 -07:00
Travis Ralston	0f8d3a66a6	Merge branch 'develop' into travis/auth-always-on	2024-11-07 09:57:41 -07:00
Travis Ralston	e90e6b80a8	Merge branch 'develop' into travis/auth-always-on	2024-10-30 11:00:13 -06:00
Travis Ralston	597fd92c98	appease linter?	2024-10-30 10:58:34 -06:00
Travis Ralston	0f65bcc26b	changelog	2024-10-30 10:56:24 -06:00
Travis Ralston	4a47ad6638	Enable authenticated media by default	2024-10-30 09:59:28 -06:00
				`@@ -0,0 +1 @@`
				Set `enable_authenticated_media` to `true` by default. In a future release of Synapse, this option will be removed and become always-on.