1
0
Commit Graph

20962 Commits

Author SHA1 Message Date
David Robertson
fda6252233 Also notify of join events via another path 2022-07-11 21:09:20 +01:00
David Robertson
47acf465ef Don't require ratelimit to notify for joins 2022-07-11 21:09:20 +01:00
David Robertson
8377172c4c Use add_hashes_and_signatures_from_other_server
- rename the method to distinguish it from `add_hashes_and_signatures`
- use it in a few other places where it makes sense
2022-07-11 21:09:19 +01:00
David Robertson
81eb4ab86a Update rate limiter in the event persister logic
Simpler, cleaner, faster, stronger.
2022-07-08 18:55:21 +01:00
David Robertson
e16294ef3b Be more explicit about the default values 2022-07-08 17:31:59 +01:00
David Robertson
9d9253109b Announce new config option in the changelog 2022-07-08 17:28:51 +01:00
David Robertson
4da8f29ff6 Tweak phrasing; note the version adding the option 2022-07-08 17:24:18 +01:00
David Robertson
dcb16831e8 Move comment translating between bucket terminology 2022-07-08 17:23:41 +01:00
David Robertson
121590a0c9 Changelog 2022-07-04 19:10:15 +01:00
David Robertson
240e32f264 Fixes to unit tests
- FederatingHomeserverTestCase: keys last 10x longer

  I am guessing that this is the first example of a test which calls
  `make_signed_federation_request` after the reactor has advanced by >=
  1 second until now.

- Increase max_request_body_size to 4KB in tests

  The previous limit prevented the master from accepting some
  replication requests which were 1.3kB in size.
2022-07-04 19:10:15 +01:00
David Robertson
7a14b94698 Test cases 2022-07-04 19:10:14 +01:00
David Robertson
0bb4122726 Snoop on replication to learn about joins on other workers 2022-07-04 19:10:14 +01:00
David Robertson
6b47e82ca2 Track per-room join rates actioned by this worker
and consult it when actioning joins.
Only bump rate limit if we will persist the event; otherwise we'll see
it over replication
2022-07-04 19:10:14 +01:00
David Robertson
4230112526 Add helper to determine if we persist event or not 2022-07-04 19:10:14 +01:00
David Robertson
ae788ca796 Replication: include outlier in event rows
Warn about replication problem in upgrade notes
2022-07-04 19:10:14 +01:00
David Robertson
77de15927a Room member: drive-by-comment 2022-07-04 19:10:14 +01:00
David Robertson
9d4cdae33a Notifier: accept callbacks to fire on room joins 2022-07-04 19:10:14 +01:00
David Robertson
c594ab774b Rate limiter: Introduce record_action 2022-07-04 19:10:14 +01:00
David Robertson
c2e3025b33 Rate limiter: Pull out some small methods 2022-07-04 19:10:14 +01:00
David Robertson
453f621d23 Rate limiter: describe leaky bucket 2022-07-04 19:10:14 +01:00
David Robertson
bd873e6571 Define config for room-level join limiter
but don't use it in tests
2022-07-04 19:10:13 +01:00
santhoshivan23
6b99a66fe0 Remove unspecced DELETE endpoint that modifies room visibility (#13123) 2022-06-28 11:22:59 +00:00
Šimon Brandner
1017f09c18 Update MSC3786 implementation: Check the state_key (#12939)
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2022-06-27 20:28:34 +01:00
Robert Long
9b683ea80f Add Cross-Origin-Resource-Policy header to thumbnail and download media endpoints (#12944) 2022-06-27 14:44:05 +01:00
reivilibre
3c5549e74a Refactor the Dockerfile-workers configuration script to use Jinja2 templates in Synapse workers' Supervisord blocks. (#13054)
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2022-06-27 11:43:20 +01:00
Aaron Raimist
3ceaf1462d Remove docs for Delete Group Admin API (#13112)
This API no longer exists.

Signed-off-by: Aaron Raimist <aaron@raim.ist>
2022-06-27 11:15:25 +01:00
santhoshivan23
d54909956e validate room alias before interacting with the room directory (#13106) 2022-06-22 15:32:18 +01:00
David Robertson
f33356e8f8 Use caret (semver bounds) for matrix.org packages (#13082) 2022-06-17 19:07:04 +01:00
Shay
3d94d07db3 Update opentracing docs to reference the configuration manual rather than the configuation file. (#13076) 2022-06-17 10:47:38 -07:00
Richard van der Hoff
d4b1c0d800 Fix inconsistencies in event validation (#13088) 2022-06-17 16:30:59 +01:00
Richard van der Hoff
e16ea87d0f Fix inconsistencies in event validation for m.room.create events (#13087)
* Extend the auth rule checks for `m.room.create` events

... and move them up to the top of the function. Since the no auth_events are
allowed for m.room.create events, we may as well get the m.room.create event
checks out of the way first.

* Add a test for create events with prev_events
2022-06-17 13:56:46 +00:00
Patrick Cloke
d3d84685ce Add type hints to event push actions tests. (#13099) 2022-06-17 12:38:13 +00:00
reivilibre
b26cbe3d45 Fix type error that made its way onto develop (#13098)
* Fix type error introduced accidentally by #13045

* Newsfile

Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2022-06-17 13:05:27 +01:00
Richard van der Hoff
5d6f55959e Update info on downstream debs (#13095) 2022-06-17 12:47:22 +01:00
Quentin Gliech
73af10f419 Simplify the alias deletion logic as an application service. (#13093) 2022-06-17 12:19:22 +01:00
Erik Johnston
5ef05c70c3 Rotate notifications more frequently (#13096) 2022-06-17 10:58:00 +00:00
Erik Johnston
5099b5ecc7 Use new device_list_changes_in_room table when getting device list changes (#13045) 2022-06-17 11:42:03 +01:00
Quentin Gliech
c6d6176411 Allow MSC3030 'timestamp_to_event' calls from anyone on world-readable rooms. (#13062)
Signed-off-by: Quentin Gliech <quenting@element.io>
2022-06-17 11:39:26 +01:00
Sean Quah
9372f6f842 Fix logging context misuse when we fail to persist a federation event (#13089)
When we fail to persist a federation event, we kick off a task to remove
its push actions in the background, using the current logging context.
Since we don't `await` that task, we may finish our logging context
before the task finishes. There's no reason to not `await` the task, so
let's do that.

Signed-off-by: Sean Quah <seanq@matrix.org>
2022-06-17 10:22:50 +01:00
Erik Johnston
8ceed5e6b5 Add desc to get_earliest_token_for_stats (#13085) 2022-06-16 17:50:46 +00:00
reivilibre
90cadcd403 Add a Subject Alternative Name to the certificate generated for Complement tests. (#13071) 2022-06-16 12:43:21 +01:00
Patrick Cloke
0fcc0ae37c Improve URL previews for sites with only Twitter card information. (#13056)
Pull out `twitter:` meta tags when generating a preview and
use it to augment any `og:` meta tags.

Prefers Open Graph information over Twitter card information.
2022-06-16 07:41:57 -04:00
reivilibre
7552615247 Reduce the duplication of code that invokes the rate limiter. (#13070) 2022-06-16 12:40:29 +01:00
Richard van der Hoff
1e0044e8f9 Complement: use SQLite by default (#13075)
If no database is configured explicitly, use sqlite.

This means that you don't have to pass any variables into the image.
2022-06-16 12:12:26 +01:00
Jacek Kuśnierz
0ef1307619 Add custom well-known (#13035)
Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
2022-06-16 11:48:18 +01:00
reivilibre
ffe2464836 Add instructions for running Complement with gotestfmt-formatted output locally. (#13073) 2022-06-16 09:31:10 +00:00
Richard van der Hoff
8ecf6be1e1 Move some event auth checks out to a different method (#13065)
* Add auth events to events used in tests

* Move some event auth checks out to a different method

Some of the event auth checks apply to an event's auth_events, rather than the
state at the event - which means they can play no part in state
resolution. Move them out to a separate method.

* Rename check_auth_rules_for_event

Now it only checks the state-dependent auth rules, it needs a better name.
2022-06-15 19:48:22 +01:00
Shay
cba1c5cbc2 Add headers to individual options in config documentation to allow for linking. (#13055) 2022-06-15 11:31:46 -07:00
Sean Quah
99d3931974 Add more tests for room upgrades (#13074)
Signed-off-by: Sean Quah <seanq@element.io>
2022-06-15 18:58:23 +01:00
Erik Johnston
c95b04bb0e Change default sync_response_cache_duration (#13042) 2022-06-15 16:55:20 +00:00