kaslo/synapse
1
0
Fork 0
Code Wiki Activity

We only have to store the state_group for events created by create_event first

Browse Source 
This gets us down to the ~0.8s per 100 event batch times!
This commit is contained in:
Eric Eastwood
2022-01-19 18:00:03 -06:00
parent 491e91dd40
commit e0b718622a
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
synapse/handlers/room_batch.py
View File

@@ -354,6 +354,16 @@ class RoomBatchHandler:
event_type_creation_cache[event.type] = EventCreationCacheItem(
event=event, context=context
)
# Normally this is done when persisting the event but we have to
# pre-emptively do it here because we create all the events first,
# then persist them in another pass below. And we want to share
# state_groups across the whole batch so this lookup needs to work
# for the next event in the batch in this loop.
await self.store.store_state_group_id_for_event_id(
event_id=event.event_id,
state_group_id=context._state_group,
)
else:
builder = self.event_builder_factory.for_room_version(
room_version_obj, event_dict
@@ -380,16 +390,6 @@ class RoomBatchHandler:
# TODO: Can we get away without this?
# self.validator.validate_new(event, self.config)
# Normally this is done when persisting the event but we have to
# pre-emptively do it here because we create all the events first,
# then persist them in another pass below. And we want to share
# state_groups across the whole batch so this lookup needs to work
# for the next event in the batch in this loop.
await self.store.store_state_group_id_for_event_id(
event_id=event.event_id,
state_group_id=context._state_group,
)
logger.debug(
"RoomBatchSendEventRestServlet inserting event=%s, prev_event_ids=%s, auth_event_ids=%s",
event,