kaslo/synapse
1
0
Fork 0
Code Wiki Activity

Use org.matrix.unstable prefix

Browse Source
This commit is contained in:
Mathieu Velten
2022-08-03 14:46:46 +02:00
parent ea8cf6edcf
commit 4cc2f3e990
3 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
changelog.d/13412.feature
View File

@@ -1 +1 @@
Add `do_not_use_to_device_limit` field to sync filter. This is an experiment to see if it improves sync performance.
Add `org.matrix.unstable.to_device_limit` field to sync filter. This is an experiment to see if it improves sync performance.

6
synapse/api/filtering.py
View File

@@ -136,7 +136,7 @@ USER_FILTER_SCHEMA = {
},
# This is an experiment, a MSC will follow if it happens to be useful
# for clients sync performance
"do_not_use_to_device_limit": {"type": "number"},
"org.matrix.unstable.to_device_limit": {"type": "number"},
},
"additionalProperties": False,
}
@@ -224,7 +224,9 @@ class FilterCollection:
self.to_device_limit = 100
if hs.config.experimental.to_device_limit_enabled:
self.to_device_limit = filter_json.get("do_not_use_to_device_limit", 100)
self.to_device_limit = filter_json.get(
"org.matrix.unstable.to_device_limit", 100
)
# We don't want to overload the server so let's limit it to under a thousand
if self.to_device_limit > 1000:
self.to_device_limit = 1000

4
tests/rest/client/test_sync.py
View File

@@ -991,7 +991,7 @@ class ToDeviceLimitTestCase(unittest.HomeserverTestCase):
)
self.assertEqual(chan.code, 200, chan.result)
# This does an incremental sync for user kermit with do_not_use_to_device_limit
# This does an incremental sync for user kermit with org.matrix.unstable.to_device_limit
# setted and check the number of returned to_device msgs against
# expected_to_device_msgs value
def _limited_sync_and_check(
@@ -999,7 +999,7 @@ class ToDeviceLimitTestCase(unittest.HomeserverTestCase):
) -> None:
channel = self.make_request(
"GET",
f'/sync?since={self.next_batch}&filter={{"do_not_use_to_device_limit": {to_device_limit}}}',
f'/sync?since={self.next_batch}&filter={{"org.matrix.unstable.to_device_limit": {to_device_limit}}}',
access_token=self.tok,
)
self.assertEqual(channel.code, 200)