kaslo/synapse
1
0
Fork 0
Code Wiki Activity

Split up deleting devices into batches (#16766)

Browse Source 
Otherwise for users with large numbers of devices this can cause a lot
of woe.
This commit is contained in:
Erik Johnston
2024-01-10 13:55:16 +00:00
committed by GitHub
parent 72e9b74bbf
commit 4c67f0391b
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/16766.misc Normal file
View File

@@ -0,0 +1 @@
Split up deleting devices into batches.

8
synapse/storage/databases/main/devices.py
View File

@@ -1794,7 +1794,7 @@ class DeviceStore(DeviceWorkerStore, DeviceBackgroundUpdateStore):
device_ids: The IDs of the devices to delete
"""
def _delete_devices_txn(txn: LoggingTransaction) -> None:
def _delete_devices_txn(txn: LoggingTransaction, device_ids: List[str]) -> None:
self.db_pool.simple_delete_many_txn(
txn,
table="devices",
@@ -1811,7 +1811,11 @@ class DeviceStore(DeviceWorkerStore, DeviceBackgroundUpdateStore):
keyvalues={"user_id": user_id},
)
await self.db_pool.runInteraction("delete_devices", _delete_devices_txn)
for batch in batch_iter(device_ids, 100):
await self.db_pool.runInteraction(
"delete_devices", _delete_devices_txn, batch
)
for device_id in device_ids:
self.device_id_exists_cache.invalidate((user_id, device_id))