Iterate over in-flight requests in descending order

2021-12-20 12:57:47 +00:00
parent d9800c3f6f
commit 3ae955ea0b
1 changed files with 6 additions and 4 deletions
@@ -296,10 +296,12 @@ class StateGroupDataStore(StateBackgroundUpdateStore, SQLBaseStore):

        state_filter_left_over = state_filter
        reusable_requests = []
-        for (
-            request_state_filter,
-            request_deferred,
-        ) in inflight_requests.items():
+
+        # Iterate over existing requests in roughly biggest-first order.
+        # reversed(inflight_requests) has an efficient iterator implementation,
+        # but reversed(inflight_requests.items()) does not, sadly.
+        for request_state_filter in reversed(inflight_requests):
+            request_deferred = inflight_requests[request_state_filter]
            new_state_filter_left_over = state_filter_left_over.approx_difference(
                request_state_filter
            )