kaslo/synapse
1
0
Fork 0
Code Wiki Activity

Fix existing unit tests

Browse Source 
There is so much mocking going on here. I look forward to replacing these one day.
This commit is contained in:
Andrew Morgan
2021-11-22 16:50:50 +00:00
committed by Olivier Wilkinson (reivilibre)
parent 75b8bd3951
commit 124bb71442
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/handlers/test_appservice.py
View File

@@ -47,12 +47,6 @@ class AppServiceHandlerTestCase(unittest.TestCase):
self.handler = ApplicationServicesHandler(hs)
self.event_source = hs.get_event_sources()
# Mock the ApplicationServiceScheduler queuer so that we can track any
# outgoing ephemeral events
self.mock_service_queuer = Mock()
self.mock_service_queuer.enqueue_ephemeral = Mock()
hs.get_application_service_handler().scheduler.queuer = self.mock_service_queuer
def test_notify_interested_services(self):
interested_service = self._mkservice(is_interested=True)
services = [
@@ -285,7 +279,7 @@ class AppServiceHandlerTestCase(unittest.TestCase):
self.handler.notify_interested_services_ephemeral(
"receipt_key", 580, ["@fakerecipient:example.com"]
)
self.mock_service_queuer.enqueue_ephemeral.assert_called_once_with(
self.mock_scheduler.submit_ephemeral_events_for_as.assert_called_once_with(
interested_service, [event]
)
self.mock_store.set_type_stream_id_for_appservice.assert_called_once_with(
@@ -315,7 +309,10 @@ class AppServiceHandlerTestCase(unittest.TestCase):
self.handler.notify_interested_services_ephemeral(
"receipt_key", 580, ["@fakerecipient:example.com"]
)
self.mock_service_queuer.enqueue_ephemeral.assert_not_called()
# This method will be called, but with an empty list of events
self.mock_scheduler.submit_ephemeral_events_for_as.assert_called_once_with(
interested_service, []
)
def _mkservice(self, is_interested, protocols=None):
service = Mock()