Don't accept opentracing data from clients. (#5715)

2020-02-19 11:47:29 +00:00
parent b93f684205 7b8bc61834
commit 11d91ee1bc
2 changed files with 2 additions and 2 deletions
--- a/changelog.d/5715.misc
+++ b/changelog.d/5715.misc
@@ -0,0 +1 @@
+Don't accept opentracing data from clients.
--- a/synapse/logging/opentracing.py
+++ b/synapse/logging/opentracing.py
@@ -340,8 +340,7 @@ def trace_servlet(servlet_name, func):
    @wraps(func)
    @defer.inlineCallbacks
    def _trace_servlet_inner(request, *args, **kwargs):
-        with start_active_span_from_context(
-            request.requestHeaders,
+        with start_active_span(
            "incoming-client-request",
            tags={
                "request_id": request.get_request_id(),
				`@@ -0,0 +1 @@`
				`Don't accept opentracing data from clients.`