Black

synapse/state/__init__.py

@@ -40,8 +40,8 @@ logger = logging.getLogger(__name__)
 
 # Metrics for number of state groups involved in a resolution.
 state_groups_histogram = Histogram(
-    "synapse_state_number_state_groups",
-    "",
+    "synapse_state_number_state_groups_in_resolution",
+    "Number of state groups used when performing a state resolution",
     buckets=(1, 2, 3, 5, 7, 10, 15, 20, 50, 100, 200, 500, "+Inf"),
 )
 

synapse/storage/events.py

@@ -77,7 +77,7 @@ state_delta_reuse_delta_counter = Counter(
 # The number of forward extremities for each new event.
 forward_extremities_counter = Histogram(
     "synapse_storage_events_forward_extremities_persisted",
-    "",
+    "Number of forward extremities for each new event",
     buckets=(1, 2, 3, 5, 7, 10, 15, 20, 50, 100, 200, 500, "+Inf"),
 )
 
@@ -85,7 +85,7 @@ forward_extremities_counter = Histogram(
 # are those that were in the previous set of extremities as well as the new.
 stale_forward_extremities_counter = Histogram(
     "synapse_storage_events_stale_forward_extremities_persisted",
-    "",
+    "Number of unchanged forward extremities for each new event",
     buckets=(0, 1, 2, 3, 5, 7, 10, 15, 20, 50, 100, 200, 500, "+Inf"),
 )
 
@@ -585,7 +585,7 @@ class EventsStore(
         # (e.g. we ignore backfill/outliers/etc)
         if result != latest_event_ids:
             forward_extremities_counter.observe(len(result))
-            stale = set(latest_event_ids) & result
+            stale = latest_event_ids & result
             stale_forward_extremities_counter.observe(len(stale))
 
         defer.returnValue(result)