kaslo/synapse
1
0
Fork 0
Code Packages Releases 124 Wiki Activity
Files
e7d98d3429902919b0dc34462153caafb4114138
synapse/tests
History
Eric Eastwood e7d98d3429 Remove sentinel logcontext in Clock utilities (looping_call, looping_call_now, call_later) (#18907) 
Part of https://github.com/element-hq/synapse/issues/18905

Lints for ensuring we use `Clock.call_later` instead of
`reactor.callLater`, etc are coming in
https://github.com/element-hq/synapse/pull/18944

### Testing strategy

 1. Configure Synapse to log at the `DEBUG` level
1. Start Synapse: `poetry run synapse_homeserver --config-path
homeserver.yaml`
1. Wait 10 seconds for the [database profiling
loop](9cc4001778/synapse/storage/database.py (L711))
to execute
1. Notice the logcontext being used for the `Total database time` log
line

Before (`sentinel`):

```
2025-09-10 16:36:58,651 - synapse.storage.TIME - 707 - DEBUG - sentinel - Total database time: 0.646% {room_forgetter_stream_pos(2): 0.131%, reap_monthly_active_users(1): 0.083%, get_device_change_last_converted_pos(1): 0.078%}
```

After (`looping_call`):

```
2025-09-10 16:36:58,651 - synapse.storage.TIME - 707 - DEBUG - looping_call - Total database time: 0.646% {room_forgetter_stream_pos(2): 0.131%, reap_monthly_active_users(1): 0.083%, get_device_change_last_converted_pos(1): 0.078%}
```
2025-09-22 14:51:13 -05:00
..
api
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
app
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
appservice
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
config
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
crypto
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
events
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
federation
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
handlers
Fix run_in_background not be awaited properly causing LoggingContext problems (#18937)
2025-09-22 10:55:45 -05:00
http
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
logging
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
media
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
metrics
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
module_api
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
push
Remove sentinel logcontext in Clock utilities (looping_call, looping_call_now, call_later) (#18907)
2025-09-22 14:51:13 -05:00
replication
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
rest
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
scripts
Update license headers
2023-11-21 15:29:58 -05:00
server_notices
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
state
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
storage
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
test_utils
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
types
Support for room version 12
2025-08-11 16:43:45 +01:00
util
Remove sentinel logcontext in Clock utilities (looping_call, looping_call_now, call_later) (#18907)
2025-09-22 14:51:13 -05:00
__init__.py
Correctly mention previous copyright (#16820)
2024-01-23 11:26:48 +00:00
server.py
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
test_distributor.py
Refactor background process metrics to be homeserver-scoped (#18670)
2025-07-23 13:28:17 -05:00
test_event_auth.py
Format files with Ruff (#17643)
2024-09-02 12:39:04 +01:00
test_mau.py
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
test_phone_home.py
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
test_rust.py
Add missing type hints to tests. (#15027)
2023-02-08 19:52:37 +00:00
test_server.py
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
test_state.py
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
test_terms_auth.py
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
test_test_utils.py
Correctly mention previous copyright (#16820)
2024-01-23 11:26:48 +00:00
test_types.py
Format files with Ruff (#17643)
2024-09-02 12:39:04 +01:00
test_visibility.py
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
unittest.py
Introduce Clock.call_when_running(...) to include logcontext by default (#18944)
2025-09-22 10:27:59 -05:00
utils.py
Refactor Histogram metrics to be homeserver-scoped (#18724)
2025-07-29 15:35:38 -05:00