Synapse 1.37.0 (2021-06-29) =========================== This release deprecates the current spam checker interface. See the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#deprecation-of-the-current-spam-checker-interface) for more information on how to update to the new generic module interface. This release also removes support for fetching and renewing TLS certificates using the ACME v1 protocol, which has been fully decommissioned by Let's Encrypt on June 1st 2021. Admins previously using this feature should use a [reverse proxy](https://matrix-org.github.io/synapse/develop/reverse_proxy.html) to handle TLS termination, or use an external ACME client (such as [certbot](https://certbot.eff.org/)) to retrieve a certificate and key and provide them to Synapse using the `tls_certificate_path` and `tls_private_key_path` configuration settings. Synapse 1.37.0rc1 (2021-06-24) ============================== Features -------- - Implement "room knocking" as per [MSC2403](https://github.com/matrix-org/matrix-doc/pull/2403). Contributed by @Sorunome and anoa. ([\#6739](https://github.com/matrix-org/synapse/issues/6739), [\#9359](https://github.com/matrix-org/synapse/issues/9359), [\#10167](https://github.com/matrix-org/synapse/issues/10167), [\#10212](https://github.com/matrix-org/synapse/issues/10212), [\#10227](https://github.com/matrix-org/synapse/issues/10227)) - Add experimental support for backfilling history into rooms ([MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716)). ([\#9247](https://github.com/matrix-org/synapse/issues/9247)) - Implement a generic interface for third-party plugin modules. ([\#10062](https://github.com/matrix-org/synapse/issues/10062), [\#10206](https://github.com/matrix-org/synapse/issues/10206)) - Implement config option `sso.update_profile_information` to sync SSO users' profile information with the identity provider each time they login. Currently only displayname is supported. ([\#10108](https://github.com/matrix-org/synapse/issues/10108)) - Ensure that errors during startup are written to the logs and the console. ([\#10191](https://github.com/matrix-org/synapse/issues/10191)) Bugfixes -------- - Fix a bug introduced in Synapse v1.25.0 that prevented the `ip_range_whitelist` configuration option from working for federation and identity servers. Contributed by @mikure. ([\#10115](https://github.com/matrix-org/synapse/issues/10115)) - Remove a broken import line in Synapse's `admin_cmd` worker. Broke in Synapse v1.33.0. ([\#10154](https://github.com/matrix-org/synapse/issues/10154)) - Fix a bug introduced in Synapse v1.21.0 which could cause `/sync` to return immediately with an empty response. ([\#10157](https://github.com/matrix-org/synapse/issues/10157), [\#10158](https://github.com/matrix-org/synapse/issues/10158)) - Fix a minor bug in the response to `/_matrix/client/r0/user/{user}/openid/request_token` causing `expires_in` to be a float instead of an integer. Contributed by @lukaslihotzki. ([\#10175](https://github.com/matrix-org/synapse/issues/10175)) - Always require users to re-authenticate for dangerous operations: deactivating an account, modifying an account password, and adding 3PIDs. ([\#10184](https://github.com/matrix-org/synapse/issues/10184)) - Fix a bug introduced in Synpase v1.7.2 where remote server count metrics collection would be incorrectly delayed on startup. Found by @heftig. ([\#10195](https://github.com/matrix-org/synapse/issues/10195)) - Fix a bug introduced in Synapse v1.35.1 where an `allow` key of a `m.room.join_rules` event could be applied for incorrect room versions and configurations. ([\#10208](https://github.com/matrix-org/synapse/issues/10208)) - Fix performance regression in responding to user key requests over federation. Introduced in Synapse v1.34.0rc1. ([\#10221](https://github.com/matrix-org/synapse/issues/10221)) Improved Documentation ---------------------- - Add a new guide to decoding request logs. ([\#8436](https://github.com/matrix-org/synapse/issues/8436)) - Mention in the sample homeserver config that you may need to configure max upload size in your reverse proxy. Contributed by @aaronraimist. ([\#10122](https://github.com/matrix-org/synapse/issues/10122)) - Fix broken links in documentation. ([\#10180](https://github.com/matrix-org/synapse/issues/10180)) - Deploy a snapshot of the documentation website upon each new Synapse release. ([\#10198](https://github.com/matrix-org/synapse/issues/10198)) Deprecations and Removals ------------------------- - The current spam checker interface is deprecated in favour of a new generic modules system. See the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#deprecation-of-the-current-spam-checker-interface) for more information on how to update to the new system. ([\#10062](https://github.com/matrix-org/synapse/issues/10062), [\#10210](https://github.com/matrix-org/synapse/issues/10210), [\#10238](https://github.com/matrix-org/synapse/issues/10238)) - Stop supporting the unstable spaces prefixes from MSC1772. ([\#10161](https://github.com/matrix-org/synapse/issues/10161)) - Remove Synapse's support for automatically fetching and renewing certificates using the ACME v1 protocol. This protocol has been fully turned off by Let's Encrypt for existing installations on June 1st 2021. Admins previously using this feature should use a [reverse proxy](https://matrix-org.github.io/synapse/develop/reverse_proxy.html) to handle TLS termination, or use an external ACME client (such as [certbot](https://certbot.eff.org/)) to retrieve a certificate and key and provide them to Synapse using the `tls_certificate_path` and `tls_private_key_path` configuration settings. ([\#10194](https://github.com/matrix-org/synapse/issues/10194)) Internal Changes ---------------- - Update the database schema versioning to support gradual migration away from legacy tables. ([\#9933](https://github.com/matrix-org/synapse/issues/9933)) - Add type hints to the federation servlets. ([\#10080](https://github.com/matrix-org/synapse/issues/10080)) - Improve OpenTracing for event persistence. ([\#10134](https://github.com/matrix-org/synapse/issues/10134), [\#10193](https://github.com/matrix-org/synapse/issues/10193)) - Clean up the interface for injecting OpenTracing over HTTP. ([\#10143](https://github.com/matrix-org/synapse/issues/10143)) - Limit the number of in-flight `/keys/query` requests from a single device. ([\#10144](https://github.com/matrix-org/synapse/issues/10144)) - Refactor EventPersistenceQueue. ([\#10145](https://github.com/matrix-org/synapse/issues/10145)) - Document `SYNAPSE_TEST_LOG_LEVEL` to see the logger output when running tests. ([\#10148](https://github.com/matrix-org/synapse/issues/10148)) - Update the Complement build tags in GitHub Actions to test currently experimental features. ([\#10155](https://github.com/matrix-org/synapse/issues/10155)) - Add a `synapse_federation_soft_failed_events_total` metric to track how often events are soft failed. ([\#10156](https://github.com/matrix-org/synapse/issues/10156)) - Fetch the corresponding complement branch when performing CI. ([\#10160](https://github.com/matrix-org/synapse/issues/10160)) - Add some developer documentation about boolean columns in database schemas. ([\#10164](https://github.com/matrix-org/synapse/issues/10164)) - Add extra logging fields to better debug where events are being soft failed. ([\#10168](https://github.com/matrix-org/synapse/issues/10168)) - Add debug logging for when we enter and exit `Measure` blocks. ([\#10183](https://github.com/matrix-org/synapse/issues/10183)) - Improve comments in structured logging code. ([\#10188](https://github.com/matrix-org/synapse/issues/10188)) - Update [MSC3083](https://github.com/matrix-org/matrix-doc/pull/3083) support with modifications from the MSC. ([\#10189](https://github.com/matrix-org/synapse/issues/10189)) - Remove redundant DNS lookup limiter. ([\#10190](https://github.com/matrix-org/synapse/issues/10190)) - Upgrade `black` linting tool to 21.6b0. ([\#10197](https://github.com/matrix-org/synapse/issues/10197)) - Expose OpenTracing trace id in response headers. ([\#10199](https://github.com/matrix-org/synapse/issues/10199))
828 lines
31 KiB
Python
828 lines
31 KiB
Python
# Copyright 2015, 2016 OpenMarket Ltd
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
from unittest.mock import Mock
|
|
|
|
from synapse.api.auth import Auth
|
|
from synapse.api.constants import UserTypes
|
|
from synapse.api.errors import Codes, ResourceLimitError, SynapseError
|
|
from synapse.events.spamcheck import load_legacy_spam_checkers
|
|
from synapse.rest.client.v2_alpha.register import (
|
|
_map_email_to_displayname,
|
|
register_servlets,
|
|
)
|
|
from synapse.spam_checker_api import RegistrationBehaviour
|
|
from synapse.types import RoomAlias, UserID, create_requester
|
|
|
|
from tests.server import FakeChannel
|
|
from tests.test_utils import make_awaitable
|
|
from tests.unittest import override_config
|
|
from tests.utils import mock_getRawHeaders
|
|
|
|
from .. import unittest
|
|
|
|
|
|
class TestSpamChecker:
|
|
def __init__(self, config, api):
|
|
api.register_spam_checker_callbacks(
|
|
check_registration_for_spam=self.check_registration_for_spam,
|
|
)
|
|
|
|
@staticmethod
|
|
def parse_config(config):
|
|
return config
|
|
|
|
async def check_registration_for_spam(
|
|
self,
|
|
email_threepid,
|
|
username,
|
|
request_info,
|
|
auth_provider_id,
|
|
):
|
|
pass
|
|
|
|
|
|
class DenyAll(TestSpamChecker):
|
|
async def check_registration_for_spam(
|
|
self,
|
|
email_threepid,
|
|
username,
|
|
request_info,
|
|
auth_provider_id,
|
|
):
|
|
return RegistrationBehaviour.DENY
|
|
|
|
|
|
class BanAll(TestSpamChecker):
|
|
async def check_registration_for_spam(
|
|
self,
|
|
email_threepid,
|
|
username,
|
|
request_info,
|
|
auth_provider_id,
|
|
):
|
|
return RegistrationBehaviour.SHADOW_BAN
|
|
|
|
|
|
class BanBadIdPUser(TestSpamChecker):
|
|
async def check_registration_for_spam(
|
|
self, email_threepid, username, request_info, auth_provider_id=None
|
|
):
|
|
# Reject any user coming from CAS and whose username contains profanity
|
|
if auth_provider_id == "cas" and "flimflob" in username:
|
|
return RegistrationBehaviour.DENY
|
|
return RegistrationBehaviour.ALLOW
|
|
|
|
|
|
class TestLegacyRegistrationSpamChecker:
|
|
def __init__(self, config, api):
|
|
pass
|
|
|
|
async def check_registration_for_spam(
|
|
self,
|
|
email_threepid,
|
|
username,
|
|
request_info,
|
|
):
|
|
pass
|
|
|
|
|
|
class LegacyAllowAll(TestLegacyRegistrationSpamChecker):
|
|
async def check_registration_for_spam(
|
|
self,
|
|
email_threepid,
|
|
username,
|
|
request_info,
|
|
):
|
|
return RegistrationBehaviour.ALLOW
|
|
|
|
|
|
class LegacyDenyAll(TestLegacyRegistrationSpamChecker):
|
|
async def check_registration_for_spam(
|
|
self,
|
|
email_threepid,
|
|
username,
|
|
request_info,
|
|
):
|
|
return RegistrationBehaviour.DENY
|
|
|
|
|
|
class RegistrationTestCase(unittest.HomeserverTestCase):
|
|
"""Tests the RegistrationHandler."""
|
|
|
|
servlets = [
|
|
register_servlets,
|
|
]
|
|
|
|
def make_homeserver(self, reactor, clock):
|
|
hs_config = self.default_config()
|
|
|
|
# some of the tests rely on us having a user consent version
|
|
hs_config["user_consent"] = {
|
|
"version": "test_consent_version",
|
|
"template_dir": ".",
|
|
}
|
|
hs_config["max_mau_value"] = 50
|
|
hs_config["limit_usage_by_mau"] = True
|
|
|
|
hs = self.setup_test_homeserver(config=hs_config)
|
|
|
|
load_legacy_spam_checkers(hs)
|
|
|
|
module_api = hs.get_module_api()
|
|
for module, config in hs.config.modules.loaded_modules:
|
|
module(config=config, api=module_api)
|
|
|
|
return hs
|
|
|
|
def prepare(self, reactor, clock, hs):
|
|
self.mock_distributor = Mock()
|
|
self.mock_distributor.declare("registered_user")
|
|
self.mock_captcha_client = Mock()
|
|
self.handler = self.hs.get_registration_handler()
|
|
self.store = self.hs.get_datastore()
|
|
self.lots_of_users = 100
|
|
self.small_number_of_users = 1
|
|
|
|
self.requester = create_requester("@requester:test")
|
|
|
|
def test_user_is_created_and_logged_in_if_doesnt_exist(self):
|
|
frank = UserID.from_string("@frank:test")
|
|
user_id = frank.to_string()
|
|
requester = create_requester(user_id)
|
|
result_user_id, result_token = self.get_success(
|
|
self.get_or_create_user(requester, frank.localpart, "Frankie")
|
|
)
|
|
self.assertEquals(result_user_id, user_id)
|
|
self.assertIsInstance(result_token, str)
|
|
self.assertGreater(len(result_token), 20)
|
|
|
|
def test_if_user_exists(self):
|
|
store = self.hs.get_datastore()
|
|
frank = UserID.from_string("@frank:test")
|
|
self.get_success(
|
|
store.register_user(user_id=frank.to_string(), password_hash=None)
|
|
)
|
|
local_part = frank.localpart
|
|
user_id = frank.to_string()
|
|
requester = create_requester(user_id)
|
|
result_user_id, result_token = self.get_success(
|
|
self.get_or_create_user(requester, local_part, None)
|
|
)
|
|
self.assertEquals(result_user_id, user_id)
|
|
self.assertTrue(result_token is not None)
|
|
|
|
def test_mau_limits_when_disabled(self):
|
|
self.hs.config.limit_usage_by_mau = False
|
|
# Ensure does not throw exception
|
|
self.get_success(self.get_or_create_user(self.requester, "a", "display_name"))
|
|
|
|
def test_get_or_create_user_mau_not_blocked(self):
|
|
self.hs.config.limit_usage_by_mau = True
|
|
self.store.count_monthly_users = Mock(
|
|
return_value=make_awaitable(self.hs.config.max_mau_value - 1)
|
|
)
|
|
# Ensure does not throw exception
|
|
self.get_success(self.get_or_create_user(self.requester, "c", "User"))
|
|
|
|
def test_get_or_create_user_mau_blocked(self):
|
|
self.hs.config.limit_usage_by_mau = True
|
|
self.store.get_monthly_active_count = Mock(
|
|
return_value=make_awaitable(self.lots_of_users)
|
|
)
|
|
self.get_failure(
|
|
self.get_or_create_user(self.requester, "b", "display_name"),
|
|
ResourceLimitError,
|
|
)
|
|
|
|
self.store.get_monthly_active_count = Mock(
|
|
return_value=make_awaitable(self.hs.config.max_mau_value)
|
|
)
|
|
self.get_failure(
|
|
self.get_or_create_user(self.requester, "b", "display_name"),
|
|
ResourceLimitError,
|
|
)
|
|
|
|
def test_register_mau_blocked(self):
|
|
self.hs.config.limit_usage_by_mau = True
|
|
self.store.get_monthly_active_count = Mock(
|
|
return_value=make_awaitable(self.lots_of_users)
|
|
)
|
|
self.get_failure(
|
|
self.handler.register_user(localpart="local_part"), ResourceLimitError
|
|
)
|
|
|
|
self.store.get_monthly_active_count = Mock(
|
|
return_value=make_awaitable(self.hs.config.max_mau_value)
|
|
)
|
|
self.get_failure(
|
|
self.handler.register_user(localpart="local_part"), ResourceLimitError
|
|
)
|
|
|
|
def test_auto_join_rooms_for_guests(self):
|
|
room_alias_str = "#room:test"
|
|
self.hs.config.auto_join_rooms = [room_alias_str]
|
|
self.hs.config.auto_join_rooms_for_guests = False
|
|
user_id = self.get_success(
|
|
self.handler.register_user(localpart="jeff", make_guest=True),
|
|
)
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
self.assertEqual(len(rooms), 0)
|
|
|
|
@override_config({"auto_join_rooms": ["#room:test"]})
|
|
def test_auto_create_auto_join_rooms(self):
|
|
room_alias_str = "#room:test"
|
|
user_id = self.get_success(self.handler.register_user(localpart="jeff"))
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
directory_handler = self.hs.get_directory_handler()
|
|
room_alias = RoomAlias.from_string(room_alias_str)
|
|
room_id = self.get_success(directory_handler.get_association(room_alias))
|
|
|
|
self.assertTrue(room_id["room_id"] in rooms)
|
|
self.assertEqual(len(rooms), 1)
|
|
|
|
def test_auto_create_auto_join_rooms_with_no_rooms(self):
|
|
self.hs.config.auto_join_rooms = []
|
|
frank = UserID.from_string("@frank:test")
|
|
user_id = self.get_success(self.handler.register_user(frank.localpart))
|
|
self.assertEqual(user_id, frank.to_string())
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
self.assertEqual(len(rooms), 0)
|
|
|
|
def test_auto_create_auto_join_where_room_is_another_domain(self):
|
|
self.hs.config.auto_join_rooms = ["#room:another"]
|
|
frank = UserID.from_string("@frank:test")
|
|
user_id = self.get_success(self.handler.register_user(frank.localpart))
|
|
self.assertEqual(user_id, frank.to_string())
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
self.assertEqual(len(rooms), 0)
|
|
|
|
def test_auto_create_auto_join_where_auto_create_is_false(self):
|
|
self.hs.config.autocreate_auto_join_rooms = False
|
|
room_alias_str = "#room:test"
|
|
self.hs.config.auto_join_rooms = [room_alias_str]
|
|
user_id = self.get_success(self.handler.register_user(localpart="jeff"))
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
self.assertEqual(len(rooms), 0)
|
|
|
|
def test_auto_create_auto_join_rooms_when_user_is_not_a_real_user(self):
|
|
room_alias_str = "#room:test"
|
|
self.hs.config.auto_join_rooms = [room_alias_str]
|
|
|
|
self.store.is_real_user = Mock(return_value=make_awaitable(False))
|
|
user_id = self.get_success(self.handler.register_user(localpart="support"))
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
self.assertEqual(len(rooms), 0)
|
|
directory_handler = self.hs.get_directory_handler()
|
|
room_alias = RoomAlias.from_string(room_alias_str)
|
|
self.get_failure(directory_handler.get_association(room_alias), SynapseError)
|
|
|
|
@override_config({"auto_join_rooms": ["#room:test"]})
|
|
def test_auto_create_auto_join_rooms_when_user_is_the_first_real_user(self):
|
|
room_alias_str = "#room:test"
|
|
|
|
self.store.count_real_users = Mock(return_value=make_awaitable(1))
|
|
self.store.is_real_user = Mock(return_value=make_awaitable(True))
|
|
user_id = self.get_success(self.handler.register_user(localpart="real"))
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
directory_handler = self.hs.get_directory_handler()
|
|
room_alias = RoomAlias.from_string(room_alias_str)
|
|
room_id = self.get_success(directory_handler.get_association(room_alias))
|
|
|
|
self.assertTrue(room_id["room_id"] in rooms)
|
|
self.assertEqual(len(rooms), 1)
|
|
|
|
def test_auto_create_auto_join_rooms_when_user_is_not_the_first_real_user(self):
|
|
room_alias_str = "#room:test"
|
|
self.hs.config.auto_join_rooms = [room_alias_str]
|
|
|
|
self.store.count_real_users = Mock(return_value=make_awaitable(2))
|
|
self.store.is_real_user = Mock(return_value=make_awaitable(True))
|
|
user_id = self.get_success(self.handler.register_user(localpart="real"))
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
self.assertEqual(len(rooms), 0)
|
|
|
|
@override_config(
|
|
{
|
|
"auto_join_rooms": ["#room:test"],
|
|
"autocreate_auto_join_rooms_federated": False,
|
|
}
|
|
)
|
|
def test_auto_create_auto_join_rooms_federated(self):
|
|
"""
|
|
Auto-created rooms that are private require an invite to go to the user
|
|
(instead of directly joining it).
|
|
"""
|
|
room_alias_str = "#room:test"
|
|
user_id = self.get_success(self.handler.register_user(localpart="jeff"))
|
|
|
|
# Ensure the room was created.
|
|
directory_handler = self.hs.get_directory_handler()
|
|
room_alias = RoomAlias.from_string(room_alias_str)
|
|
room_id = self.get_success(directory_handler.get_association(room_alias))
|
|
|
|
# Ensure the room is properly not federated.
|
|
room = self.get_success(self.store.get_room_with_stats(room_id["room_id"]))
|
|
self.assertFalse(room["federatable"])
|
|
self.assertFalse(room["public"])
|
|
self.assertEqual(room["join_rules"], "public")
|
|
self.assertIsNone(room["guest_access"])
|
|
|
|
# The user should be in the room.
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
self.assertIn(room_id["room_id"], rooms)
|
|
|
|
@override_config(
|
|
{"auto_join_rooms": ["#room:test"], "auto_join_mxid_localpart": "support"}
|
|
)
|
|
def test_auto_join_mxid_localpart(self):
|
|
"""
|
|
Ensure the user still needs up in the room created by a different user.
|
|
"""
|
|
# Ensure the support user exists.
|
|
inviter = "@support:test"
|
|
|
|
room_alias_str = "#room:test"
|
|
user_id = self.get_success(self.handler.register_user(localpart="jeff"))
|
|
|
|
# Ensure the room was created.
|
|
directory_handler = self.hs.get_directory_handler()
|
|
room_alias = RoomAlias.from_string(room_alias_str)
|
|
room_id = self.get_success(directory_handler.get_association(room_alias))
|
|
|
|
# Ensure the room is properly a public room.
|
|
room = self.get_success(self.store.get_room_with_stats(room_id["room_id"]))
|
|
self.assertEqual(room["join_rules"], "public")
|
|
|
|
# Both users should be in the room.
|
|
rooms = self.get_success(self.store.get_rooms_for_user(inviter))
|
|
self.assertIn(room_id["room_id"], rooms)
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
self.assertIn(room_id["room_id"], rooms)
|
|
|
|
# Register a second user, which should also end up in the room.
|
|
user_id = self.get_success(self.handler.register_user(localpart="bob"))
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
self.assertIn(room_id["room_id"], rooms)
|
|
|
|
@override_config(
|
|
{
|
|
"auto_join_rooms": ["#room:test"],
|
|
"autocreate_auto_join_room_preset": "private_chat",
|
|
"auto_join_mxid_localpart": "support",
|
|
}
|
|
)
|
|
def test_auto_create_auto_join_room_preset(self):
|
|
"""
|
|
Auto-created rooms that are private require an invite to go to the user
|
|
(instead of directly joining it).
|
|
"""
|
|
# Ensure the support user exists.
|
|
inviter = "@support:test"
|
|
|
|
room_alias_str = "#room:test"
|
|
user_id = self.get_success(self.handler.register_user(localpart="jeff"))
|
|
|
|
# Ensure the room was created.
|
|
directory_handler = self.hs.get_directory_handler()
|
|
room_alias = RoomAlias.from_string(room_alias_str)
|
|
room_id = self.get_success(directory_handler.get_association(room_alias))
|
|
|
|
# Ensure the room is properly a private room.
|
|
room = self.get_success(self.store.get_room_with_stats(room_id["room_id"]))
|
|
self.assertFalse(room["public"])
|
|
self.assertEqual(room["join_rules"], "invite")
|
|
self.assertEqual(room["guest_access"], "can_join")
|
|
|
|
# Both users should be in the room.
|
|
rooms = self.get_success(self.store.get_rooms_for_user(inviter))
|
|
self.assertIn(room_id["room_id"], rooms)
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
self.assertIn(room_id["room_id"], rooms)
|
|
|
|
# Register a second user, which should also end up in the room.
|
|
user_id = self.get_success(self.handler.register_user(localpart="bob"))
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
self.assertIn(room_id["room_id"], rooms)
|
|
|
|
@override_config(
|
|
{
|
|
"auto_join_rooms": ["#room:test"],
|
|
"autocreate_auto_join_room_preset": "private_chat",
|
|
"auto_join_mxid_localpart": "support",
|
|
}
|
|
)
|
|
def test_auto_create_auto_join_room_preset_guest(self):
|
|
"""
|
|
Auto-created rooms that are private require an invite to go to the user
|
|
(instead of directly joining it).
|
|
|
|
This should also work for guests.
|
|
"""
|
|
inviter = "@support:test"
|
|
|
|
room_alias_str = "#room:test"
|
|
user_id = self.get_success(
|
|
self.handler.register_user(localpart="jeff", make_guest=True)
|
|
)
|
|
|
|
# Ensure the room was created.
|
|
directory_handler = self.hs.get_directory_handler()
|
|
room_alias = RoomAlias.from_string(room_alias_str)
|
|
room_id = self.get_success(directory_handler.get_association(room_alias))
|
|
|
|
# Ensure the room is properly a private room.
|
|
room = self.get_success(self.store.get_room_with_stats(room_id["room_id"]))
|
|
self.assertFalse(room["public"])
|
|
self.assertEqual(room["join_rules"], "invite")
|
|
self.assertEqual(room["guest_access"], "can_join")
|
|
|
|
# Both users should be in the room.
|
|
rooms = self.get_success(self.store.get_rooms_for_user(inviter))
|
|
self.assertIn(room_id["room_id"], rooms)
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
self.assertIn(room_id["room_id"], rooms)
|
|
|
|
@override_config(
|
|
{
|
|
"auto_join_rooms": ["#room:test"],
|
|
"autocreate_auto_join_room_preset": "private_chat",
|
|
"auto_join_mxid_localpart": "support",
|
|
}
|
|
)
|
|
def test_auto_create_auto_join_room_preset_invalid_permissions(self):
|
|
"""
|
|
Auto-created rooms that are private require an invite, check that
|
|
registration doesn't completely break if the inviter doesn't have proper
|
|
permissions.
|
|
"""
|
|
inviter = "@support:test"
|
|
|
|
# Register an initial user to create the room and such (essentially this
|
|
# is a subset of test_auto_create_auto_join_room_preset).
|
|
room_alias_str = "#room:test"
|
|
user_id = self.get_success(self.handler.register_user(localpart="jeff"))
|
|
|
|
# Ensure the room was created.
|
|
directory_handler = self.hs.get_directory_handler()
|
|
room_alias = RoomAlias.from_string(room_alias_str)
|
|
room_id = self.get_success(directory_handler.get_association(room_alias))
|
|
|
|
# Ensure the room exists.
|
|
self.get_success(self.store.get_room_with_stats(room_id["room_id"]))
|
|
|
|
# Both users should be in the room.
|
|
rooms = self.get_success(self.store.get_rooms_for_user(inviter))
|
|
self.assertIn(room_id["room_id"], rooms)
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
self.assertIn(room_id["room_id"], rooms)
|
|
|
|
# Lower the permissions of the inviter.
|
|
event_creation_handler = self.hs.get_event_creation_handler()
|
|
requester = create_requester(inviter)
|
|
event, context = self.get_success(
|
|
event_creation_handler.create_event(
|
|
requester,
|
|
{
|
|
"type": "m.room.power_levels",
|
|
"state_key": "",
|
|
"room_id": room_id["room_id"],
|
|
"content": {"invite": 100, "users": {inviter: 0}},
|
|
"sender": inviter,
|
|
},
|
|
)
|
|
)
|
|
self.get_success(
|
|
event_creation_handler.handle_new_client_event(requester, event, context)
|
|
)
|
|
|
|
# Register a second user, which won't be be in the room (or even have an invite)
|
|
# since the inviter no longer has the proper permissions.
|
|
user_id = self.get_success(self.handler.register_user(localpart="bob"))
|
|
|
|
# This user should not be in any rooms.
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
invited_rooms = self.get_success(
|
|
self.store.get_invited_rooms_for_local_user(user_id)
|
|
)
|
|
self.assertEqual(rooms, set())
|
|
self.assertEqual(invited_rooms, [])
|
|
|
|
def test_auto_create_auto_join_where_no_consent(self):
|
|
"""Test to ensure that the first user is not auto-joined to a room if
|
|
they have not given general consent.
|
|
"""
|
|
|
|
# Given:-
|
|
# * a user must give consent,
|
|
# * they have not given that consent
|
|
# * The server is configured to auto-join to a room
|
|
# (and autocreate if necessary)
|
|
|
|
event_creation_handler = self.hs.get_event_creation_handler()
|
|
# (Messing with the internals of event_creation_handler is fragile
|
|
# but can't see a better way to do this. One option could be to subclass
|
|
# the test with custom config.)
|
|
event_creation_handler._block_events_without_consent_error = "Error"
|
|
event_creation_handler._consent_uri_builder = Mock()
|
|
room_alias_str = "#room:test"
|
|
self.hs.config.auto_join_rooms = [room_alias_str]
|
|
|
|
# When:-
|
|
# * the user is registered and post consent actions are called
|
|
user_id = self.get_success(self.handler.register_user(localpart="jeff"))
|
|
self.get_success(self.handler.post_consent_actions(user_id))
|
|
|
|
# Then:-
|
|
# * Ensure that they have not been joined to the room
|
|
rooms = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
self.assertEqual(len(rooms), 0)
|
|
|
|
def test_register_support_user(self):
|
|
user_id = self.get_success(
|
|
self.handler.register_user(localpart="user", user_type=UserTypes.SUPPORT)
|
|
)
|
|
d = self.store.is_support_user(user_id)
|
|
self.assertTrue(self.get_success(d))
|
|
|
|
def test_register_not_support_user(self):
|
|
user_id = self.get_success(self.handler.register_user(localpart="user"))
|
|
d = self.store.is_support_user(user_id)
|
|
self.assertFalse(self.get_success(d))
|
|
|
|
def test_invalid_user_id_length(self):
|
|
invalid_user_id = "x" * 256
|
|
self.get_failure(
|
|
self.handler.register_user(localpart=invalid_user_id), SynapseError
|
|
)
|
|
|
|
@override_config(
|
|
{
|
|
"modules": [
|
|
{
|
|
"module": TestSpamChecker.__module__ + ".DenyAll",
|
|
}
|
|
]
|
|
}
|
|
)
|
|
def test_spam_checker_deny(self):
|
|
"""A spam checker can deny registration, which results in an error."""
|
|
self.get_failure(self.handler.register_user(localpart="user"), SynapseError)
|
|
|
|
@override_config(
|
|
{
|
|
"spam_checker": [
|
|
{
|
|
"module": TestSpamChecker.__module__ + ".LegacyAllowAll",
|
|
}
|
|
]
|
|
}
|
|
)
|
|
def test_spam_checker_legacy_allow(self):
|
|
"""Tests that a legacy spam checker implementing the legacy 3-arg version of the
|
|
check_registration_for_spam callback is correctly called.
|
|
|
|
In this test and the following one we test both success and failure to make sure
|
|
any failure comes from the spam checker (and not something else failing in the
|
|
call stack) and any success comes from the spam checker (and not because a
|
|
misconfiguration prevented it from being loaded).
|
|
"""
|
|
self.get_success(self.handler.register_user(localpart="user"))
|
|
|
|
@override_config(
|
|
{
|
|
"spam_checker": [
|
|
{
|
|
"module": TestSpamChecker.__module__ + ".LegacyDenyAll",
|
|
}
|
|
]
|
|
}
|
|
)
|
|
def test_spam_checker_legacy_deny(self):
|
|
"""Tests that a legacy spam checker implementing the legacy 3-arg version of the
|
|
check_registration_for_spam callback is correctly called.
|
|
|
|
In this test and the previous one we test both success and failure to make sure
|
|
any failure comes from the spam checker (and not something else failing in the
|
|
call stack) and any success comes from the spam checker (and not because a
|
|
misconfiguration prevented it from being loaded).
|
|
"""
|
|
self.get_failure(self.handler.register_user(localpart="user"), SynapseError)
|
|
|
|
@override_config(
|
|
{
|
|
"modules": [
|
|
{
|
|
"module": TestSpamChecker.__module__ + ".BanAll",
|
|
}
|
|
]
|
|
}
|
|
)
|
|
def test_spam_checker_shadow_ban(self):
|
|
"""A spam checker can choose to shadow-ban a user, which allows registration to succeed."""
|
|
user_id = self.get_success(self.handler.register_user(localpart="user"))
|
|
|
|
# Get an access token.
|
|
token = "testtok"
|
|
self.get_success(
|
|
self.store.add_access_token_to_user(
|
|
user_id=user_id, token=token, device_id=None, valid_until_ms=None
|
|
)
|
|
)
|
|
|
|
# Ensure the user was marked as shadow-banned.
|
|
request = Mock(args={})
|
|
request.args[b"access_token"] = [token.encode("ascii")]
|
|
request.requestHeaders.getRawHeaders = mock_getRawHeaders()
|
|
auth = Auth(self.hs)
|
|
requester = self.get_success(auth.get_user_by_req(request))
|
|
|
|
self.assertTrue(requester.shadow_banned)
|
|
|
|
@override_config(
|
|
{
|
|
"modules": [
|
|
{
|
|
"module": TestSpamChecker.__module__ + ".BanBadIdPUser",
|
|
}
|
|
]
|
|
}
|
|
)
|
|
def test_spam_checker_receives_sso_type(self):
|
|
"""Test rejecting registration based on SSO type"""
|
|
f = self.get_failure(
|
|
self.handler.register_user(localpart="bobflimflob", auth_provider_id="cas"),
|
|
SynapseError,
|
|
)
|
|
exception = f.value
|
|
|
|
# We return 429 from the spam checker for denied registrations
|
|
self.assertIsInstance(exception, SynapseError)
|
|
self.assertEqual(exception.code, 429)
|
|
|
|
# Check the same username can register using SAML
|
|
self.get_success(
|
|
self.handler.register_user(localpart="bobflimflob", auth_provider_id="saml")
|
|
)
|
|
|
|
def test_email_to_displayname_mapping(self):
|
|
"""Test that custom emails are mapped to new user displaynames correctly"""
|
|
self._check_mapping(
|
|
"jack-phillips.rivers@big-org.com", "Jack-Phillips Rivers [Big-Org]"
|
|
)
|
|
|
|
self._check_mapping("bob.jones@matrix.org", "Bob Jones [Tchap Admin]")
|
|
|
|
self._check_mapping("bob-jones.blabla@gouv.fr", "Bob-Jones Blabla [Gouv]")
|
|
|
|
# Multibyte unicode characters
|
|
self._check_mapping(
|
|
"j\u030a\u0065an-poppy.seed@example.com",
|
|
"J\u030a\u0065an-Poppy Seed [Example]",
|
|
)
|
|
|
|
def _check_mapping(self, i, expected):
|
|
result = _map_email_to_displayname(i)
|
|
self.assertEqual(result, expected)
|
|
|
|
@override_config(
|
|
{
|
|
"bind_new_user_emails_to_sydent": "https://is.example.com",
|
|
"registrations_require_3pid": ["email"],
|
|
"account_threepid_delegates": {},
|
|
"email": {
|
|
"smtp_host": "127.0.0.1",
|
|
"smtp_port": 20,
|
|
"require_transport_security": False,
|
|
"smtp_user": None,
|
|
"smtp_pass": None,
|
|
"notif_from": "test@example.com",
|
|
},
|
|
"public_baseurl": "http://localhost",
|
|
}
|
|
)
|
|
def test_user_email_bound_via_sydent_internal_api(self):
|
|
"""Tests that emails are bound after registration if this option is set"""
|
|
# Register user with an email address
|
|
email = "alice@example.com"
|
|
|
|
# Mock Synapse's threepid validator
|
|
get_threepid_validation_session = Mock(
|
|
return_value=make_awaitable(
|
|
{"medium": "email", "address": email, "validated_at": 0}
|
|
)
|
|
)
|
|
self.store.get_threepid_validation_session = get_threepid_validation_session
|
|
delete_threepid_session = Mock(return_value=make_awaitable(None))
|
|
self.store.delete_threepid_session = delete_threepid_session
|
|
|
|
# Mock Synapse's http json post method to check for the internal bind call
|
|
post_json_get_json = Mock(return_value=make_awaitable(None))
|
|
self.hs.get_identity_handler().http_client.post_json_get_json = (
|
|
post_json_get_json
|
|
)
|
|
|
|
# Retrieve a UIA session ID
|
|
channel = self.uia_register(
|
|
401, {"username": "alice", "password": "nobodywillguessthis"}
|
|
)
|
|
session_id = channel.json_body["session"]
|
|
|
|
# Register our email address using the fake validation session above
|
|
channel = self.uia_register(
|
|
200,
|
|
{
|
|
"username": "alice",
|
|
"password": "nobodywillguessthis",
|
|
"auth": {
|
|
"session": session_id,
|
|
"type": "m.login.email.identity",
|
|
"threepid_creds": {"sid": "blabla", "client_secret": "blablabla"},
|
|
},
|
|
},
|
|
)
|
|
self.assertEqual(channel.json_body["user_id"], "@alice:test")
|
|
|
|
# Check that a bind attempt was made to our fake identity server
|
|
post_json_get_json.assert_called_with(
|
|
"https://is.example.com/_matrix/identity/internal/bind",
|
|
{"address": "alice@example.com", "medium": "email", "mxid": "@alice:test"},
|
|
)
|
|
|
|
# Check that we stored a mapping of this bind
|
|
bound_threepids = self.get_success(
|
|
self.store.user_get_bound_threepids("@alice:test")
|
|
)
|
|
self.assertListEqual(bound_threepids, [{"medium": "email", "address": email}])
|
|
|
|
def uia_register(self, expected_response: int, body: dict) -> FakeChannel:
|
|
"""Make a register request."""
|
|
channel = self.make_request("POST", "register", body)
|
|
|
|
self.assertEqual(channel.code, expected_response)
|
|
return channel
|
|
|
|
async def get_or_create_user(
|
|
self, requester, localpart, displayname, password_hash=None
|
|
):
|
|
"""Creates a new user if the user does not exist,
|
|
else revokes all previous access tokens and generates a new one.
|
|
|
|
XXX: this used to be in the main codebase, but was only used by this file,
|
|
so got moved here. TODO: get rid of it, probably
|
|
|
|
Args:
|
|
localpart : The local part of the user ID to register. If None,
|
|
one will be randomly generated.
|
|
Returns:
|
|
A tuple of (user_id, access_token).
|
|
"""
|
|
if localpart is None:
|
|
raise SynapseError(400, "Request must include user id")
|
|
await self.hs.get_auth().check_auth_blocking()
|
|
need_register = True
|
|
|
|
try:
|
|
await self.handler.check_username(localpart)
|
|
except SynapseError as e:
|
|
if e.errcode == Codes.USER_IN_USE:
|
|
need_register = False
|
|
else:
|
|
raise
|
|
|
|
user = UserID(localpart, self.hs.hostname)
|
|
user_id = user.to_string()
|
|
token = self.hs.get_auth_handler().generate_access_token(user)
|
|
|
|
if need_register:
|
|
await self.handler.register_with_store(
|
|
user_id=user_id,
|
|
password_hash=password_hash,
|
|
create_profile_with_displayname=user.localpart,
|
|
)
|
|
else:
|
|
await self.hs.get_auth_handler().delete_access_tokens_for_user(user_id)
|
|
|
|
await self.store.add_access_token_to_user(
|
|
user_id=user_id, token=token, device_id=None, valid_until_ms=None
|
|
)
|
|
|
|
if displayname is not None:
|
|
# logger.info("setting user display name: %s -> %s", user_id, displayname)
|
|
await self.hs.get_profile_handler().set_displayname(
|
|
user, requester, displayname, by_admin=True
|
|
)
|
|
|
|
return user_id, token
|