Fix remote images being chosen over the local ones we just built with
Complement in CI (any Docker environment using the `containerd` image
store). This problem means that Complement jobs in CI don't actually
test against the code from the PR (since 2026-02-10).
This PR approaches the problem the same way that @AndrewFerr proposed in
https://github.com/element-hq/synapse/pull/18210. This is better than
the alternative listed below as we can just make our code compatible
with whatever image store is being used.
### Problem
Spawning from
https://github.com/element-hq/synapse/pull/19460#discussion_r2818760635
where we found that our Complement jobs in CI don't actually test
against the code from the PR at the moment.
This is caused by a change in Docker Engine 29.0.0:
> `containerd` image store is now the default for **fresh installs**.
This doesn't apply to daemons configured with `userns-remap` (see
[moby#47377](https://github.com/moby/moby/issues/47377)).
>
> *-- 29.0.0 (2025-11-10),
https://docs.docker.com/engine/release-notes/29/#2900*
And our `ubuntu-latest` GitHub runner (`Current runner version:
'2.331.0'`)
[points](https://github.com/actions/runner-images/blob/ubuntu24/20260209.23/images/ubuntu/Ubuntu2404-Readme.md)
to using Docker client/server `29.1.5` 🎯
This Docker version bump happened on
416418df15
(2026-02-10) (`28.0.4` -> `29.1.5`). Specific PR:
https://github.com/actions/runner-images/pull/13633
---
I found this because I reviewed and remembered
https://github.com/element-hq/synapse/pull/18210 was a thing that
@AndrewFerr ran into. And then running `dockers system prune` also
revealed the problematic `containerd` in CI. Checking the Docker
changelogs, I found the new default culprit and then could trace down
where the GitHub runners made the dependency update.
---------
Co-authored-by: Andrew Ferrazzutti <andrewf@element.io>
391 lines
14 KiB
Bash
Executable File
391 lines
14 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# This script is designed for developers who want to test their code
|
|
# against Complement.
|
|
#
|
|
# It makes a Synapse image which represents the current checkout,
|
|
# builds a synapse-complement image on top, then runs tests with it.
|
|
#
|
|
# By default the script will fetch the latest Complement main branch and
|
|
# run tests with that. This can be overridden to use a custom Complement
|
|
# checkout by setting the COMPLEMENT_DIR environment variable to the
|
|
# filepath of a local Complement checkout or by setting the COMPLEMENT_REF
|
|
# environment variable to pull a different branch or commit.
|
|
#
|
|
# To use the 'podman' command instead 'docker', set the PODMAN environment
|
|
# variable. Example:
|
|
#
|
|
# PODMAN=1 ./complement.sh
|
|
#
|
|
# By default Synapse is run in monolith mode. This can be overridden by
|
|
# setting the WORKERS environment variable.
|
|
#
|
|
# You can optionally give a "-f" argument (for "fast") before any to skip
|
|
# rebuilding the docker images, if you just want to rerun the tests.
|
|
#
|
|
# Remaining commandline arguments are passed through to `go test`. For example,
|
|
# you can supply a regular expression of test method names via the "-run"
|
|
# argument:
|
|
#
|
|
# ./complement.sh -run "TestOutboundFederation(Profile|Send)"
|
|
#
|
|
# Specifying TEST_ONLY_SKIP_DEP_HASH_VERIFICATION=1 will cause `poetry export`
|
|
# to not emit any hashes when building the Docker image. This then means that
|
|
# you can use 'unverifiable' sources such as git repositories as dependencies.
|
|
|
|
# Exit if a line returns a non-zero exit code
|
|
set -e
|
|
|
|
# Tag local builds with a dummy registry namespace so that later builds may reference
|
|
# them exactly instead of accidentally pulling from a remote registry.
|
|
#
|
|
# This is important as some storage drivers/types prefer remote images over local
|
|
# (`containerd`) which causes problems as we're testing against some remote image that
|
|
# doesn't include all of the changes that we're trying to test (be it locally or in a PR
|
|
# in CI). This is spawning from a real-world problem where the GitHub runners were
|
|
# updated to use Docker Engine 29.0.0+ which uses `containerd` by default for new
|
|
# installations.
|
|
LOCAL_IMAGE_NAMESPACE=localhost
|
|
|
|
# The image tags for how these images will be stored in the registry
|
|
SYNAPSE_IMAGE_PATH="$LOCAL_IMAGE_NAMESPACE/synapse"
|
|
SYNAPSE_WORKERS_IMAGE_PATH="$LOCAL_IMAGE_NAMESPACE/synapse-workers"
|
|
COMPLEMENT_SYNAPSE_IMAGE_PATH="$LOCAL_IMAGE_NAMESPACE/complement-synapse"
|
|
|
|
SYNAPSE_EDITABLE_IMAGE_PATH="$LOCAL_IMAGE_NAMESPACE/synapse-editable"
|
|
SYNAPSE_WORKERS_EDITABLE_IMAGE_PATH="$LOCAL_IMAGE_NAMESPACE/synapse-workers-editable"
|
|
COMPLEMENT_SYNAPSE_EDITABLE_IMAGE_PATH="$LOCAL_IMAGE_NAMESPACE/complement-synapse-editable"
|
|
|
|
# Helper to emit annotations that collapse portions of the log in GitHub Actions
|
|
echo_if_github() {
|
|
if [[ -n "$GITHUB_WORKFLOW" ]]; then
|
|
echo $*
|
|
fi
|
|
}
|
|
|
|
# Helper to print out the usage instructions
|
|
usage() {
|
|
cat >&2 <<EOF
|
|
Usage: $0 [-f] <go test arguments>...
|
|
Run the complement test suite on Synapse.
|
|
--in-repo
|
|
Whether to run the in-repo suite of Complement tests (see `./complement` in this project)
|
|
vs the Complement tests from the Complement repo.
|
|
|
|
-f, --fast
|
|
Skip rebuilding the docker images, and just use the most recent
|
|
'localhost/complement-synapse:latest' image.
|
|
Conflicts with --build-only.
|
|
|
|
--build-only
|
|
Only build the Docker images. Don't actually run Complement.
|
|
Conflicts with -f/--fast.
|
|
|
|
-e, --editable
|
|
Use an editable build of Synapse, rebuilding the image if necessary.
|
|
This is suitable for use in development where a fast turn-around time
|
|
is important.
|
|
Not suitable for use in CI in case the editable environment is impure.
|
|
|
|
--rebuild-editable
|
|
Force a rebuild of the editable build of Synapse.
|
|
This is occasionally useful if the built-in rebuild detection with
|
|
--editable fails, e.g. when changing configure_workers_and_start.py.
|
|
|
|
For help on arguments to 'go test', run 'go help testflag'.
|
|
EOF
|
|
}
|
|
|
|
# We use a function to wrap the script logic so that we can use `return` to exit early
|
|
# if needed. This is particularly useful so that this script can be sourced by other
|
|
# scripts without exiting the calling subshell (composable). This allows us to share
|
|
# variables like `SYNAPSE_SUPPORTED_COMPLEMENT_TEST_PACKAGES` with other scripts.
|
|
#
|
|
# Returns an exit code of 0 on success, or 1 on failure.
|
|
main() {
|
|
# parse our arguments
|
|
skip_docker_build=""
|
|
skip_complement_run=""
|
|
use_in_repo_tests=""
|
|
while [ $# -ge 1 ]; do
|
|
arg=$1
|
|
case "$arg" in
|
|
"-h")
|
|
usage
|
|
return 1
|
|
;;
|
|
"--in-repo")
|
|
use_in_repo_tests=1
|
|
;;
|
|
"-f"|"--fast")
|
|
skip_docker_build=1
|
|
;;
|
|
"--build-only")
|
|
skip_complement_run=1
|
|
;;
|
|
"-e"|"--editable")
|
|
use_editable_synapse=1
|
|
;;
|
|
"--rebuild-editable")
|
|
rebuild_editable_synapse=1
|
|
;;
|
|
*)
|
|
# unknown arg: presumably an argument to gotest. break the loop.
|
|
break
|
|
esac
|
|
shift
|
|
done
|
|
|
|
# enable buildkit for the docker builds
|
|
export DOCKER_BUILDKIT=1
|
|
|
|
# Determine whether to use the docker or podman container runtime.
|
|
if [ -n "$PODMAN" ]; then
|
|
export CONTAINER_RUNTIME=podman
|
|
export DOCKER_HOST=unix://$XDG_RUNTIME_DIR/podman/podman.sock
|
|
export BUILDAH_FORMAT=docker
|
|
export COMPLEMENT_HOSTNAME_RUNNING_COMPLEMENT=host.containers.internal
|
|
else
|
|
export CONTAINER_RUNTIME=docker
|
|
fi
|
|
|
|
# Change to the repository root
|
|
cd "$(dirname $0)/.."
|
|
|
|
# Check for a user-specified Complement checkout
|
|
if [[ -z "$COMPLEMENT_DIR" ]]; then
|
|
COMPLEMENT_REF=${COMPLEMENT_REF:-main}
|
|
echo "COMPLEMENT_DIR not set. Fetching Complement checkout from ${COMPLEMENT_REF}..."
|
|
wget -Nq https://github.com/matrix-org/complement/archive/${COMPLEMENT_REF}.tar.gz
|
|
tar -xzf ${COMPLEMENT_REF}.tar.gz
|
|
COMPLEMENT_DIR=complement-${COMPLEMENT_REF}
|
|
echo "Checkout available at 'complement-${COMPLEMENT_REF}'"
|
|
fi
|
|
|
|
if [ -n "$use_editable_synapse" ]; then
|
|
if [[ -e synapse/synapse_rust.abi3.so ]]; then
|
|
# In an editable install, back up the host's compiled Rust module to prevent
|
|
# inconvenience; the container will overwrite the module with its own copy.
|
|
mv -n synapse/synapse_rust.abi3.so synapse/synapse_rust.abi3.so~host
|
|
# And restore it on exit:
|
|
synapse_pkg=`realpath synapse`
|
|
trap "mv -f '$synapse_pkg/synapse_rust.abi3.so~host' '$synapse_pkg/synapse_rust.abi3.so'" EXIT
|
|
fi
|
|
|
|
editable_mount="$(realpath .):/editable-src:z"
|
|
if [ -n "$rebuild_editable_synapse" ]; then
|
|
unset skip_docker_build
|
|
elif $CONTAINER_RUNTIME inspect "$COMPLEMENT_SYNAPSE_EDITABLE_IMAGE_PATH" &>/dev/null; then
|
|
# complement-synapse-editable already exists: see if we can still use it:
|
|
# - The Rust module must still be importable; it will fail to import if the Rust source has changed.
|
|
# - The Poetry lock file must be the same (otherwise we assume dependencies have changed)
|
|
|
|
# First set up the module in the right place for an editable installation.
|
|
$CONTAINER_RUNTIME run --rm -v $editable_mount --entrypoint 'cp' "$COMPLEMENT_SYNAPSE_EDITABLE_IMAGE_PATH" -- /synapse_rust.abi3.so.bak /editable-src/synapse/synapse_rust.abi3.so
|
|
|
|
if ($CONTAINER_RUNTIME run --rm -v $editable_mount --entrypoint 'python' "$COMPLEMENT_SYNAPSE_EDITABLE_IMAGE_PATH" -c 'import synapse.synapse_rust' \
|
|
&& $CONTAINER_RUNTIME run --rm -v $editable_mount --entrypoint 'diff' "$COMPLEMENT_SYNAPSE_EDITABLE_IMAGE_PATH" --brief /editable-src/poetry.lock /poetry.lock.bak); then
|
|
skip_docker_build=1
|
|
else
|
|
echo "Editable Synapse image is stale. Will rebuild."
|
|
unset skip_docker_build
|
|
fi
|
|
fi
|
|
fi
|
|
|
|
if [ -z "$skip_docker_build" ]; then
|
|
if [ -n "$use_editable_synapse" ]; then
|
|
|
|
# Build a special image designed for use in development with editable
|
|
# installs.
|
|
$CONTAINER_RUNTIME build \
|
|
-t "$SYNAPSE_EDITABLE_IMAGE_PATH" \
|
|
-f "docker/editable.Dockerfile" .
|
|
|
|
$CONTAINER_RUNTIME build \
|
|
-t "$SYNAPSE_WORKERS_EDITABLE_IMAGE_PATH" \
|
|
--build-arg FROM="$SYNAPSE_EDITABLE_IMAGE_PATH" \
|
|
-f "docker/Dockerfile-workers" .
|
|
|
|
$CONTAINER_RUNTIME build \
|
|
-t "$COMPLEMENT_SYNAPSE_EDITABLE_IMAGE_PATH" \
|
|
--build-arg FROM="$SYNAPSE_WORKERS_EDITABLE_IMAGE_PATH" \
|
|
-f "docker/complement/Dockerfile" "docker/complement"
|
|
|
|
# Prepare the Rust module
|
|
$CONTAINER_RUNTIME run --rm -v $editable_mount --entrypoint 'cp' "$COMPLEMENT_SYNAPSE_EDITABLE_IMAGE_PATH" -- /synapse_rust.abi3.so.bak /editable-src/synapse/synapse_rust.abi3.so
|
|
|
|
else
|
|
|
|
# Build the base Synapse image from the local checkout
|
|
echo_if_github "::group::Build Docker image: matrixdotorg/synapse"
|
|
$CONTAINER_RUNTIME build \
|
|
-t "$SYNAPSE_IMAGE_PATH" \
|
|
--build-arg TEST_ONLY_SKIP_DEP_HASH_VERIFICATION \
|
|
--build-arg TEST_ONLY_IGNORE_POETRY_LOCKFILE \
|
|
-f "docker/Dockerfile" .
|
|
echo_if_github "::endgroup::"
|
|
|
|
# Build the workers docker image (from the base Synapse image we just built).
|
|
echo_if_github "::group::Build Docker image: matrixdotorg/synapse-workers"
|
|
$CONTAINER_RUNTIME build \
|
|
-t "$SYNAPSE_WORKERS_IMAGE_PATH" \
|
|
--build-arg FROM="$SYNAPSE_IMAGE_PATH" \
|
|
-f "docker/Dockerfile-workers" .
|
|
echo_if_github "::endgroup::"
|
|
|
|
# Build the unified Complement image (from the worker Synapse image we just built).
|
|
echo_if_github "::group::Build Docker image: complement/Dockerfile"
|
|
$CONTAINER_RUNTIME build \
|
|
-t "$COMPLEMENT_SYNAPSE_IMAGE_PATH" \
|
|
--build-arg FROM="$SYNAPSE_WORKERS_IMAGE_PATH" \
|
|
-f "docker/complement/Dockerfile" "docker/complement"
|
|
echo_if_github "::endgroup::"
|
|
|
|
fi
|
|
|
|
echo "Docker images built."
|
|
else
|
|
echo "Skipping Docker image build as requested."
|
|
fi
|
|
|
|
# Default set of Complement tests to run from the Complement repo
|
|
#
|
|
# We pick and choose the specific MSC's that Synapse supports.
|
|
default_complement_test_packages=(
|
|
./tests/csapi
|
|
./tests
|
|
./tests/msc3874
|
|
./tests/msc3890
|
|
./tests/msc3391
|
|
./tests/msc3757
|
|
./tests/msc3930
|
|
./tests/msc3902
|
|
./tests/msc3967
|
|
./tests/msc4140
|
|
./tests/msc4155
|
|
./tests/msc4306
|
|
)
|
|
|
|
# Export the list of test packages as a space-separated environment variable, so other
|
|
# scripts can use it.
|
|
export SYNAPSE_SUPPORTED_COMPLEMENT_TEST_PACKAGES="${default_complement_test_packages[@]}"
|
|
|
|
# Default set of Complement tests to run when using the in-repo test suite. Most
|
|
# likely, this should be all tests.
|
|
#
|
|
# Relative to the `./complement` repo in this project
|
|
default_in_repo_complement_test_packages=(
|
|
./tests/...
|
|
)
|
|
|
|
export COMPLEMENT_BASE_IMAGE="$COMPLEMENT_SYNAPSE_IMAGE_PATH"
|
|
if [ -n "$use_editable_synapse" ]; then
|
|
export COMPLEMENT_BASE_IMAGE="$COMPLEMENT_SYNAPSE_EDITABLE_IMAGE_PATH"
|
|
export COMPLEMENT_HOST_MOUNTS="$editable_mount"
|
|
fi
|
|
|
|
# Enable dirty runs, so tests will reuse the same container where possible.
|
|
# This significantly speeds up tests, but increases the possibility of test pollution.
|
|
export COMPLEMENT_ENABLE_DIRTY_RUNS=1
|
|
|
|
# All environment variables starting with PASS_ will be shared.
|
|
# (The prefix is stripped off before reaching the container.)
|
|
export COMPLEMENT_SHARE_ENV_PREFIX=PASS_
|
|
|
|
# * -count=1: Only run tests once, and disable caching for tests.
|
|
# * -v: Output test logs, even if those tests pass.
|
|
# * -tags=synapse_blacklist: Enable the `synapse_blacklist` build tag, which is
|
|
# necessary for `runtime.Synapse` checks/skips to work in the tests
|
|
test_args=(
|
|
-v
|
|
-tags="synapse_blacklist"
|
|
-count=1
|
|
)
|
|
|
|
# It takes longer than 10m to run the whole suite.
|
|
test_args+=("-timeout=60m")
|
|
|
|
if [[ -n "$WORKERS" ]]; then
|
|
# Use workers.
|
|
export PASS_SYNAPSE_COMPLEMENT_USE_WORKERS=true
|
|
|
|
# Pass through the workers defined. If none, it will be an empty string
|
|
export PASS_SYNAPSE_WORKER_TYPES="$WORKER_TYPES"
|
|
|
|
# Workers can only use Postgres as a database.
|
|
export PASS_SYNAPSE_COMPLEMENT_DATABASE=postgres
|
|
|
|
# And provide some more configuration to complement.
|
|
|
|
# It can take quite a while to spin up a worker-mode Synapse for the first
|
|
# time (the main problem is that we start 14 python processes for each test,
|
|
# and complement likes to do two of them in parallel).
|
|
export COMPLEMENT_SPAWN_HS_TIMEOUT_SECS=120
|
|
else
|
|
export PASS_SYNAPSE_COMPLEMENT_USE_WORKERS=
|
|
if [[ -n "$POSTGRES" ]]; then
|
|
export PASS_SYNAPSE_COMPLEMENT_DATABASE=postgres
|
|
else
|
|
export PASS_SYNAPSE_COMPLEMENT_DATABASE=sqlite
|
|
fi
|
|
fi
|
|
|
|
if [[ -n "$ASYNCIO_REACTOR" ]]; then
|
|
# Enable the Twisted asyncio reactor
|
|
export PASS_SYNAPSE_COMPLEMENT_USE_ASYNCIO_REACTOR=true
|
|
fi
|
|
|
|
if [[ -n "$UNIX_SOCKETS" ]]; then
|
|
# Enable full on Unix socket mode for Synapse, Redis and Postgresql
|
|
export PASS_SYNAPSE_USE_UNIX_SOCKET=1
|
|
fi
|
|
|
|
if [[ -n "$SYNAPSE_TEST_LOG_LEVEL" ]]; then
|
|
# Set the log level to what is desired
|
|
export PASS_SYNAPSE_LOG_LEVEL="$SYNAPSE_TEST_LOG_LEVEL"
|
|
|
|
# Allow logging sensitive things (currently SQL queries & parameters).
|
|
# (This won't have any effect if we're not logging at DEBUG level overall.)
|
|
# Since this is just a test suite, this is fine and won't reveal anyone's
|
|
# personal information
|
|
export PASS_SYNAPSE_LOG_SENSITIVE=1
|
|
fi
|
|
|
|
# Log a few more useful things for a developer attempting to debug something
|
|
# particularly tricky.
|
|
export PASS_SYNAPSE_LOG_TESTING=1
|
|
|
|
if [ -n "$skip_complement_run" ]; then
|
|
echo "Skipping Complement run as requested."
|
|
return 0
|
|
fi
|
|
|
|
# Print out the executed commands so it's more obvious what's happening at the end here.
|
|
# Things are slightly ambiguous with the in-repo vs Complement tests.
|
|
set -x
|
|
|
|
if [ -n "$use_in_repo_tests" ]; then
|
|
# Run the suite of Complement tests in the `./complement` directory in this repo
|
|
cd "./complement"
|
|
go test "${test_args[@]}" "$@" "${default_in_repo_complement_test_packages[@]}"
|
|
else
|
|
# Run the tests (from the Complement repo)!
|
|
cd "$COMPLEMENT_DIR"
|
|
go test "${test_args[@]}" "$@" "${default_complement_test_packages[@]}"
|
|
fi
|
|
|
|
# We don't need to print out executed commands anymore
|
|
#
|
|
# This is just `set +x` without printing `+ set +x` to the console (via
|
|
# https://stackoverflow.com/questions/13195655/bash-set-x-without-it-being-printed/19226038#19226038)
|
|
{ set +x; } 2>/dev/null
|
|
}
|
|
|
|
main "$@"
|
|
# For any non-zero exit code (indicating some sort of error happened), we want to exit
|
|
# with that code.
|
|
exit_code=$?
|
|
if [ $exit_code -ne 0 ]; then
|
|
exit $exit_code
|
|
fi
|