From b928909795a8df5cf888f5a22bd99ec82a6601ef Mon Sep 17 00:00:00 2001 From: "Olivier Wilkinson (reivilibre)" Date: Fri, 30 Aug 2019 15:36:49 +0100 Subject: [PATCH] Fix incremental processor when there are no deltas. Signed-off-by: Olivier Wilkinson (reivilibre) --- synapse/handlers/stats.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/synapse/handlers/stats.py b/synapse/handlers/stats.py index f44adfc07b..6341c3244e 100644 --- a/synapse/handlers/stats.py +++ b/synapse/handlers/stats.py @@ -98,15 +98,16 @@ class StatsHandler(StateDeltasHandler): self.pos["state_delta_stream_id"] ) - logger.debug("Handling %d state deltas", len(deltas)) - yield self._handle_deltas(deltas) + if deltas: + logger.debug("Handling %d state deltas", len(deltas)) + yield self._handle_deltas(deltas) - self.pos["state_delta_stream_id"] = deltas[-1]["stream_id"] - yield self.store.update_stats_positions(self.pos) + self.pos["state_delta_stream_id"] = deltas[-1]["stream_id"] + yield self.store.update_stats_positions(self.pos) - event_processing_positions.labels("stats").set( - self.pos["state_delta_stream_id"] - ) + event_processing_positions.labels("stats").set( + self.pos["state_delta_stream_id"] + ) # Then count deltas for total_events and total_event_bytes. with Measure(self.clock, "stats_total_events_and_bytes"):