kaslo/synapse
1
0
Fork 0
Code Packages Releases 124 Wiki Activity

Try dumping the whole response in Request.write directly

Browse Source
This commit is contained in:
Eric Eastwood
2025-08-20 17:50:30 -05:00
parent 40edb10a98
commit ac59dc1a59
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
synapse/http/server.py
View File

@@ -909,6 +909,9 @@ def _write_bytes_to_request(request: Request, bytes_to_write: bytes) -> None:
large response bodies. large response bodies.
""" """
request.write(bytes_to_write)
request.finish()
# The problem with dumping all of the response into the `Request` object at # The problem with dumping all of the response into the `Request` object at
# once (via `Request.write`) is that doing so starts the timeout for the # once (via `Request.write`) is that doing so starts the timeout for the
# next request to be received: so if it takes longer than 60s to stream back # next request to be received: so if it takes longer than 60s to stream back
@@ -919,12 +922,12 @@ def _write_bytes_to_request(request: Request, bytes_to_write: bytes) -> None:
# To make sure we don't write all of the bytes at once we split it up into # To make sure we don't write all of the bytes at once we split it up into
# chunks. # chunks.
chunk_size = 4096 # chunk_size = 4096
bytes_generator = chunk_seq(bytes_to_write, chunk_size) # bytes_generator = chunk_seq(bytes_to_write, chunk_size)
# We use a `_ByteProducer` here rather than `NoRangeStaticProducer` as the # # We use a `_ByteProducer` here rather than `NoRangeStaticProducer` as the
# unit tests can't cope with being given a pull producer. # # unit tests can't cope with being given a pull producer.
_ByteProducer(request, bytes_generator) # _ByteProducer(request, bytes_generator)
def set_cors_headers(request: "SynapseRequest") -> None: def set_cors_headers(request: "SynapseRequest") -> None: