From 786dd9b4b181e8836eaaf5755707157ff52373cd Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Fri, 29 Jul 2022 17:06:43 -0500 Subject: [PATCH] Explain weird function --- synapse/logging/tracing.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/synapse/logging/tracing.py b/synapse/logging/tracing.py index 2ba68d69ea..5aa05ee9a2 100644 --- a/synapse/logging/tracing.py +++ b/synapse/logging/tracing.py @@ -610,6 +610,8 @@ def inject_active_span_context_into_header_dict( return active_span = get_active_span() + # This doesn't affect the current context at all, it just converts a span + # into `Context` object basically (bad name). ctx = opentelemetry.trace.propagation.set_span_in_context(active_span) propagator = opentelemetry.propagate.get_global_textmap() @@ -649,6 +651,8 @@ def get_active_span_text_map(destination: Optional[str] = None) -> Dict[str, str return {} active_span = get_active_span() + # This doesn't affect the current context at all, it just converts a span + # into `Context` object basically (bad name). ctx = opentelemetry.trace.propagation.set_span_in_context(active_span) carrier_text_map: Dict[str, str] = {}