kaslo/synapse
1
0
Fork 0
Code Packages Releases 124 Wiki Activity

Limit size of user directory search queries (#18172)

Browse Source 
If a user search has many words we can end up creating really large
queries that take a long time for the database to process. Generally,
such searches don't return any results anyway (due to limits on user ID
and display name length).

We "fix" this by cheating and only searching for the first ten words.
This commit is contained in:
Erik Johnston
2025-02-17 16:39:26 +01:00
committed by GitHub
parent e462950338
commit 0c31783b4f
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/18172.misc Normal file
View File

@@ -0,0 +1 @@
Reduce database load of user search when using large search terms.

8
synapse/storage/databases/main/user_directory.py
View File

@@ -1237,7 +1237,13 @@ def _parse_query_postgres(search_term: str) -> Tuple[str, str, str]:
search_term = _filter_text_for_index(search_term) search_term = _filter_text_for_index(search_term)
escaped_words = [] escaped_words = []
for word in _parse_words(search_term): for index, word in enumerate(_parse_words(search_term)):
if index >= 10:
# We limit how many terms we include, as otherwise it can use
# excessive database time if people accidentally search for large
# strings.
break
# Postgres tsvector and tsquery quoting rules: # Postgres tsvector and tsquery quoting rules:
# words potentially containing punctuation should be quoted # words potentially containing punctuation should be quoted
# and then existing quotes and backslashes should be doubled # and then existing quotes and backslashes should be doubled