3ae9f4e8e6
merge: Accept Like(Note) and Update(Note) activities where the Note isn't already cached ( resolves #795 and #748 ) ( !729 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/729
Closes #795 and #748
Approved-by: dakkar <dakkar@thenautilus.net >
Approved-by: Marie <github@yuugi.dev >
2024-11-22 23:02:39 +00:00
7e3f519a5b
merge: Fix note hiding when renote and target have different visibility settings ( resolves #803 ) ( !741 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/741
Closes #803
Approved-by: dakkar <dakkar@thenautilus.net >
Approved-by: Marie <github@yuugi.dev >
2024-11-22 19:35:19 +00:00
9d5bc6cb28
pass resolver when creating notes via side-effect
2024-11-22 09:16:52 -05:00
9d3321fca4
allow Update(Note) and Update(Poll) to implicitly create missing notes
2024-11-22 09:16:48 -05:00
47eb0daebb
fetch target note of Like(Note) activities
2024-11-22 09:16:03 -05:00
2ac36e4a5c
merge: Fix federation error "The note creation failed with duplication error even when there is no duplication" ( resolves #749 ) ( !745 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/745
Closes #749
Approved-by: Tess K <me@thvxl.se >
Approved-by: dakkar <dakkar@thenautilus.net >
2024-11-22 10:37:11 +00:00
4b5a400264
merge: Allow Update activities for non-note posts ( resolves #794 ) ( !728 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/728
Closes #794
Approved-by: Tess K <me@thvxl.se >
Approved-by: dakkar <dakkar@thenautilus.net >
2024-11-22 10:35:21 +00:00
5b72c08a68
merge: Fix type confusion with exceptions in AP handling ( resolves #796 ) ( !730 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/730
Closes #796
Approved-by: dakkar <dakkar@thenautilus.net >
Approved-by: Tess K <me@thvxl.se >
2024-11-21 16:44:54 +00:00
9f3b97effb
merge: Reduce log spam from ApPersonService.updateFeatured ( !747 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/747
Approved-by: dakkar <dakkar@thenautilus.net >
Approved-by: Tess K <me@thvxl.se >
2024-11-21 16:35:18 +00:00
34a5dbe21b
merge: Reduce log spam from charts ( !748 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/748
Approved-by: dakkar <dakkar@thenautilus.net >
Approved-by: Tess K <me@thvxl.se >
2024-11-21 16:32:32 +00:00
241b186a8a
merge: Prevent "mark instance as NSFW" from producing hellspawns ( !749 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/749
Approved-by: Tess K <me@thvxl.se >
Approved-by: dakkar <dakkar@thenautilus.net >
2024-11-21 05:26:41 +00:00
4b503f88e1
normalize naming of isPackedPureRenote and PackedPureRenote
2024-11-20 22:27:52 -05:00
faf1b3559a
fix note hiding when renote and target have different visibility settings
2024-11-20 22:27:50 -05:00
bcc20d6dc4
allow Update activities for non-note posts
2024-11-20 22:08:20 -05:00
0de7a084a9
fix exception handling for Undo activities
2024-11-20 22:05:10 -05:00
cfc3ab4b04
fix exception handling for Announce activities
2024-11-20 22:05:10 -05:00
8f42e8434e
fix exception handling for Like activities
2024-11-20 22:05:10 -05:00
dff465000c
fix import-order in ApInboxService
2024-11-20 22:05:10 -05:00
0f6d26e065
reduce log spam from charts
2024-11-20 22:03:32 -05:00
c9934c379f
remove duplicate isPureRenote method
2024-11-20 22:03:17 -05:00
a62e4f1cf2
ignore isNSFW for pure renotes
2024-11-20 22:03:17 -05:00
dcd5b6d972
replace console.error with this.logger.error (merge error)
2024-11-20 22:02:59 -05:00
fedf0d7e20
further reduce log spam from updateFeatured errors
2024-11-20 22:02:59 -05:00
984cfe358d
reduce log spam from updateFeatured
2024-11-20 22:02:59 -05:00
aabb1945e8
respect pinned note limit for remote users
2024-11-20 22:02:47 -05:00
4e0f7ced84
preserve the raw URI in parseUri
2024-11-20 22:02:31 -05:00
6027b516e1
Fix .punyHost misuse
2024-11-20 21:24:35 -05:00
36af07abe2
Fix another style error
2024-11-20 20:31:22 -05:00
23c4aa2571
Fix style error
2024-11-20 20:24:59 -05:00
fa3cf6c299
Fix type error in security fixes
2024-11-20 20:06:46 -05:00
776f6fd1f5
fix(backend): allow fetchSummaryFromProxy, trueMail to access local addresses
2024-11-20 19:17:25 -05:00
7b3e3f8e25
fix(backend): add isLocalAddressAllowed option to getAgentByUrl and send (HttpRequestService)
2024-11-20 19:17:25 -05:00
360d71278a
fix(backend): lint and typecheck
2024-11-20 19:17:25 -05:00
663c06be00
Apply suggestions from code review
...
Co-authored-by: anatawa12 <anatawa12@icloud.com >
2024-11-20 19:17:25 -05:00
7ccccf5545
fix(backend): allow accessing private IP when testing
2024-11-20 19:17:25 -05:00
f36f4b5398
fix(backend): check target IP before sending HTTP request
2024-11-20 19:17:25 -05:00
cc4e99fdde
fix: Try using CacheService to avoid excess db lookups
...
This isn't perfect, theoretically if some massive number of users
blocked the user making this request the set lookup could take a long
amount of time, but eh, it works, and that scenario is highly unlikely.
2024-11-20 19:17:25 -05:00
5764fa55cb
fix: primitives 25-33: proper local instance checks
2024-11-20 19:17:25 -05:00
74565f67f7
fix: primitives 21, 22, and 23: reuse resolver
...
This also increases the default `recursionLimit` for `Resolver`, as it
theoretically will go higher that it previously would and could possibly
fail on non-malicious collection activities.
2024-11-20 19:17:25 -05:00
408e782507
fix: primitive 19 & 20: respect blocks and hide more
...
Ideally, the user property should also be hidden (as leaving it in leaks
information slightly), but given the schema of the note endpoint, I
don't think that would be possible without introducing some kind of
"ghost" user, who is attributed for posts by users who have you blocked.
2024-11-20 19:17:25 -05:00
c04f344049
fix: primitive 13: check attribution against actor in notes
2024-11-20 19:17:25 -05:00
b9080da75d
fix: code style for primitive 17
2024-11-20 19:17:24 -05:00
4d925fc086
fix: primitive 17: note same-origin identifier validation can be bypassed by wrapping the id in an array
2024-11-20 19:17:24 -05:00
b74e2e9167
fix: primitive 16: improper same-origin validation for user uri and url
2024-11-20 19:17:24 -05:00
ebea1a2962
fix: primitive 15: improper same-origin validation for note uri and url
2024-11-20 19:17:24 -05:00
4c432c07cb
fix: code style for primitive 14
2024-11-20 19:17:24 -05:00
322b3b677f
fix: primitive 14: improper validation of outbox, followers, following & shared inbox collections
2024-11-20 19:17:24 -05:00
1c7e05ce9e
fix: primitive 7 & 12: prevent poll spoofing
2024-11-20 19:17:24 -05:00
174dfb83d0
fix: primitive 6: reject anonymous objects that were fetched by their id
2024-11-20 19:17:24 -05:00
1e14612f0e
fix: primitive 4: missing same-origin identifier validation of collection-wrapped activities
2024-11-20 19:17:24 -05:00
dakkar