kaslo/pawkey-sk
1
0
Fork 0
mirror of https://git.boykissers.com/pawkey/pawkey-sk.git synced 2025-12-20 12:14:18 +00:00
Code Packages Activity

bypass rate limits when factor is 0

Browse Source
This commit is contained in:
Hazelnoot
2024-12-08 11:58:57 -05:00
parent 6fa0f2230e
commit 91c9b67cb0
2 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
packages/backend/test/unit/server/api/SkRateLimiterServiceTests.ts
View File

@@ -300,10 +300,11 @@ describe(SkRateLimiterService, () => {
expect(counter?.t).toBe(0);
});
it('should throw if factor is zero', async () => {
const promise = serviceUnderTest().limit(limit, actor, 0);
it('should skip if factor is zero', async () => {
const info = await serviceUnderTest().limit(limit, actor, 0);
await expect(promise).rejects.toThrow(/factor is zero or negative/);
expect(info.blocked).toBeFalsy();
expect(info.remaining).toBe(Number.MAX_SAFE_INTEGER);
});
it('should throw if factor is negative', async () => {
@@ -537,10 +538,11 @@ describe(SkRateLimiterService, () => {
expect(minCounter?.t).toBe(0);
});
it('should throw if factor is zero', async () => {
const promise = serviceUnderTest().limit(limit, actor, 0);
it('should skip if factor is zero', async () => {
const info = await serviceUnderTest().limit(limit, actor, 0);
await expect(promise).rejects.toThrow(/factor is zero or negative/);
expect(info.blocked).toBeFalsy();
expect(info.remaining).toBe(Number.MAX_SAFE_INTEGER);
});
it('should throw if factor is negative', async () => {
@@ -693,10 +695,11 @@ describe(SkRateLimiterService, () => {
expect(i2.blocked).toBeFalsy();
});
it('should throw if factor is zero', async () => {
const promise = serviceUnderTest().limit(limit, actor, 0);
it('should skip if factor is zero', async () => {
const info = await serviceUnderTest().limit(limit, actor, 0);
await expect(promise).rejects.toThrow(/factor is zero or negative/);
expect(info.blocked).toBeFalsy();
expect(info.remaining).toBe(Number.MAX_SAFE_INTEGER);
});
it('should throw if factor is negative', async () => {